Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to intra-doc links in core::result #75727

Merged
merged 3 commits into from
Aug 21, 2020

Conversation

camelid
Copy link
Member

@camelid camelid commented Aug 20, 2020

Part of #75080.

@rustbot modify labels: A-intra-doc-links T-doc T-rustdoc

@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2020
@rustbot rustbot added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 20, 2020
library/core/src/result.rs Outdated Show resolved Hide resolved
Can't link from `core` to `std` yet.
library/core/src/result.rs Outdated Show resolved Hide resolved
@jyn514
Copy link
Member

jyn514 commented Aug 20, 2020

r? @jyn514

@rust-highfive rust-highfive assigned jyn514 and unassigned cramertj Aug 20, 2020
library/core/src/result.rs Outdated Show resolved Hide resolved
One of the original links was linking to the wrong thing as well.

Co-authored-by: Joshua Nelson <joshua@yottadb.com>
@jyn514
Copy link
Member

jyn514 commented Aug 21, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 21, 2020

📌 Commit 5a307cf has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 21, 2020
Rollup of 5 pull requests

Successful merges:

 - rust-lang#75324 (clarify documentation of remove_dir errors)
 - rust-lang#75532 (Fix RFC-1014 test)
 - rust-lang#75664 (Update mailmap for mati865)
 - rust-lang#75727 (Switch to intra-doc links in `core::result`)
 - rust-lang#75750 (Move to intra doc links for std::thread documentation)

Failed merges:

r? @ghost
@bors bors merged commit cccb889 into rust-lang:master Aug 21, 2020
@jyn514 jyn514 removed the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 25, 2020
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants