-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to intra-doc links in core::result
#75727
Merged
bors
merged 3 commits into
rust-lang:master
from
camelid:intra-doc-links-for-core-result
Aug 21, 2020
Merged
Switch to intra-doc links in core::result
#75727
bors
merged 3 commits into
rust-lang:master
from
camelid:intra-doc-links-for-core-result
Aug 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Aug 20, 2020
rustbot
added
A-intra-doc-links
Area: Intra-doc links, the ability to link to items in docs by name
A-docs
Area: documentation for any part of the project, including the compiler, standard library, and tools
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Aug 20, 2020
camelid
commented
Aug 20, 2020
Can't link from `core` to `std` yet.
camelid
commented
Aug 20, 2020
r? @jyn514 |
jyn514
reviewed
Aug 20, 2020
One of the original links was linking to the wrong thing as well. Co-authored-by: Joshua Nelson <joshua@yottadb.com>
@bors r+ rollup |
📌 Commit 5a307cf has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 21, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 21, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#75324 (clarify documentation of remove_dir errors) - rust-lang#75532 (Fix RFC-1014 test) - rust-lang#75664 (Update mailmap for mati865) - rust-lang#75727 (Switch to intra-doc links in `core::result`) - rust-lang#75750 (Move to intra doc links for std::thread documentation) Failed merges: r? @ghost
jyn514
removed
the
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
label
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-docs
Area: documentation for any part of the project, including the compiler, standard library, and tools
A-intra-doc-links
Area: Intra-doc links, the ability to link to items in docs by name
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #75080.
@rustbot modify labels: A-intra-doc-links T-doc T-rustdoc