Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor byteorder to std in rustc_middle #75741

Merged
merged 5 commits into from
Sep 5, 2020
Merged

Refactor byteorder to std in rustc_middle #75741

merged 5 commits into from
Sep 5, 2020

Conversation

workingjubilee
Copy link
Member

Use std::io::{Read, Write} and {to, from}_{le, be}_bytes methods in
order to remove byteorder from librustc_middle's dependency graph.

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2020
@workingjubilee workingjubilee force-pushed the refactor-byteorder branch 3 times, most recently from 09f6b30 to 3f4e682 Compare August 20, 2020 12:58
@workingjubilee workingjubilee force-pushed the refactor-byteorder branch 2 times, most recently from 0f08382 to cb4673d Compare August 20, 2020 23:22
@bors
Copy link
Contributor

bors commented Aug 30, 2020

☔ The latest upstream changes (presumably #74862) made this pull request unmergeable. Please resolve the merge conflicts.

@workingjubilee workingjubilee force-pushed the refactor-byteorder branch 2 times, most recently from 2f7654e to b688314 Compare August 31, 2020 04:07
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Sep 4, 2020

📌 Commit b688314 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2020
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Sep 4, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 4, 2020
@Dylan-DPC
Rollup merge of rust-lang#75741 - workingjubilee:refactor-byteorder, …
e818838 
…r=matthewjasper

Refactor byteorder to std in rustc_middle

Use std::io::{Read, Write} and {to, from}_{le, be}_bytes methods in
order to remove byteorder from librustc_middle's dependency graph.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Sep 4, 2020
Closed
@bors
Copy link
Contributor

bors commented Sep 5, 2020

☔ The latest upstream changes (presumably #75173) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 5, 2020
@workingjubilee
Refactor byteorder to std in rustc_middle
b97d413 
Use std::io::{Read, Write} and {to, from}_{le, be}_bytes methods in
order to remove byteorder from librustc_middle's dependency graph.
@workingjubilee
Remove reference to byteorder limits
74b4eea
workingjubilee and others added 3 commits September 4, 2020 21:51
@workingjubilee @matklad
Be explicit that we're handling bytes
fe2a867 
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
@workingjubilee
Explain contract of {read, write}_target_uint
dc00eff
@workingjubilee @matthewjasper
Fix big endian read/write
2df552b 
Co-authored-by: matthewjasper <mjjasper1@gmail.com>
@workingjubilee
Copy link
Member Author

bors plz.
@bors r+ <_<
OK that probably won't work but
@rustbot modify labels: -S-waiting-on-author, +S-waiting-on-review
might.

@bors
Copy link
Contributor

bors commented Sep 5, 2020

@workingjubilee: 🔑 Insufficient privileges: Not in reviewers

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 5, 2020
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Sep 5, 2020

📌 Commit 2df552b has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 5, 2020
@Dylan-DPC
Rollup merge of rust-lang#75741 - workingjubilee:refactor-byteorder, …
b1b4512 
…r=matthewjasper

Refactor byteorder to std in rustc_middle

Use std::io::{Read, Write} and {to, from}_{le, be}_bytes methods in
order to remove byteorder from librustc_middle's dependency graph.
This was referenced Sep 5, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 5, 2020
@bors
Auto merge of rust-lang#76376 - Dylan-DPC:rollup-8chsbw9, r=Dylan-DPC
7d289ae 
Rollup of 11 pull requests

Successful merges:

 - rust-lang#75695 (Add a regression test for issue-72793)
 - rust-lang#75741 (Refactor byteorder to std in rustc_middle)
 - rust-lang#75954 (Unstable Book: add links to tracking issues for FFI features)
 - rust-lang#75994 (`impl Rc::new_cyclic`)
 - rust-lang#76060 (Link vec doc to & reference)
 - rust-lang#76078 (Remove disambiguators from intra doc link text)
 - rust-lang#76082 (Fix intra-doc links on pub re-exports)
 - rust-lang#76254 (Fold length constant in Rvalue::Repeat)
 - rust-lang#76258 (x.py check checks tests/examples/benches)
 - rust-lang#76263 (inliner: Check for codegen fn attributes compatibility)
 - rust-lang#76285 (Move jointness censoring to proc_macro)

Failed merges:

r? @ghost
@bors bors merged commit e160d2b into rust-lang:master Sep 5, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 5, 2020
@workingjubilee workingjubilee deleted the refactor-byteorder branch April 23, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewjasper matthewjasper matthewjasper left review comments

@tesuji tesuji tesuji left review comments

@matklad matklad matklad left review comments

@crlf0710 crlf0710 crlf0710 left review comments

Assignees

@matthewjasper matthewjasper

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
8 participants
@workingjubilee @rust-highfive @bors @matthewjasper @crlf0710 @matklad @tesuji @rustbot