Run cancel-outdated-builds after fully setting up the env #76018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors p=100 rollup=never I'll babysit landing this PR, since the only way to check if this works (without messing up half our CI configuration) is to see if it indeed works when doing an auto build :) |
Mark-Simulacrum
approved these changes
Aug 28, 2020
|
@bors r+ |
|
📌 Commit 19d072f has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 19d072f with merge c10ce7a53cb149c4c53462c24b1c18093fc1ac87... |
|
It's working!
|
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
What. @bors retry |
bors
added
S-waiting-on-bors
|
@pietroalbini I ran into the same issue in #75916 (comment) |
jyn514
added
the
T-infra
|
☀️ Test successful - checks-actions, checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #75995 not working as expected.
Due to GitHub Actions limitations the environment variables set in the build matrix definition are not added by the GHA runner, but by the
setup-environment.shscript. Before this PR thecancel-outdated-buildsaction was started before that script, so it was never able to detect the "suppression" variable added in #75995. This PR reorders the jobs to make suresetup-environment.shruns before the action.r? @Mark-Simulacrum