Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove disambiguators from intra doc link text #76078

Merged
merged 6 commits into from
Sep 5, 2020
Merged

Remove disambiguators from intra doc link text #76078

merged 6 commits into from
Sep 5, 2020

Commits on Sep 3, 2020

  1. Remove needless .to_owned() for link

    @jyn514
    jyn514 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    89ae59a View commit details
    Browse the repository at this point in the history

  2. Refactor ItemLink into its own struct

    @jyn514
    jyn514 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    d5495e2 View commit details
    Browse the repository at this point in the history

  3. Refactor RenderedLink into its own type

    @jyn514
    jyn514 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    31a7b6e View commit details
    Browse the repository at this point in the history

  4. Remove disambiguators from link text 

    Related to rust-lang#65354

- Pass through the replacement text to `markdown.rs`
- Add some tests
- Add a state machine that actually replaces the text when parsing Markdown
    @jyn514
    jyn514 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    9815010 View commit details
    Browse the repository at this point in the history

  5. display_for -> suggestion_for

    @jyn514
    jyn514 committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    9d7e797 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Misc cleanup 

    - Preserve suffixes when displaying
- Rename test file to match `intra-link*`
- Remove unnecessary .clone()s
- Improve comments and naming
- Fix more bugs and add tests
- Escape intra-doc link example in public documentation
    @jyn514
    jyn514 committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    18c14fd View commit details
    Browse the repository at this point in the history