-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info about !
and impl Trait
#76099
Merged
Merged
Commits on Aug 30, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4aae781 - Browse repository at this point
Copy the full SHA 4aae781View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd985e2 - Browse repository at this point
Copy the full SHA fd985e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d9a2ab - Browse repository at this point
Copy the full SHA 0d9a2abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 26eab6a - Browse repository at this point
Copy the full SHA 26eab6aView commit details -
Be more specific about polymorphic return types
I no longer say "polymorphic" since it's a bit ambiguous here.
Configuration menu - View commit details
-
Copy full SHA for 80dcad9 - Browse repository at this point
Copy the full SHA 80dcad9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd31962 - Browse repository at this point
Copy the full SHA bd31962View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e2548f - Browse repository at this point
Copy the full SHA 7e2548fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 37ea97c - Browse repository at this point
Copy the full SHA 37ea97cView commit details
Commits on Sep 1, 2020
-
Redefine
Debug
instead of importing itThis reverts commit 7e2548f. Now I know why it was redefined: it seems like it's potentially because of the orphan rule. Here are the error messages: error[E0119]: conflicting implementations of trait `std::fmt::Debug` for type `!`: --> src/primitive_docs.rs:236:1 | 6 | impl Debug for ! { | ^^^^^^^^^^^^^^^^ | = note: conflicting implementation in crate `core`: - impl std::fmt::Debug for !; error[E0117]: only traits defined in the current crate can be implemented for arbitrary types --> src/primitive_docs.rs:236:1 | 6 | impl Debug for ! { | ^^^^^^^^^^^^^^^- | | | | | `!` is not defined in the current crate | impl doesn't use only types from inside the current crate | = note: define and implement a trait or new type instead
Configuration menu - View commit details
-
Copy full SHA for e13a701 - Browse repository at this point
Copy the full SHA e13a701View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdd6f11 - Browse repository at this point
Copy the full SHA cdd6f11View commit details -
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
Configuration menu - View commit details
-
Copy full SHA for c4c058c - Browse repository at this point
Copy the full SHA c4c058cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 913354b - Browse repository at this point
Copy the full SHA 913354bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 55637f5 - Browse repository at this point
Copy the full SHA 55637f5View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.