Rollup of 9 pull requests #76152
Closed
Rollup of 9 pull requests #76152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reference counted pointer -> reference-counted pointer
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
Passing --disable-per-crate-search removes the create search inputs so moved code around so that the search input is enabled first before the function returns
Clarify what the state of Vec after with_capacity on doc.
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
Added the `mingw-w64-x86_64-ninja` package to the build guide for MinGW, as well as a note not to use the `ninja` package from the `msys2` subsystem (doesn't handle paths correctly on windows).
Switch to intra-doc links in core/src/{convert,iter}/mod.rs
Partial fix for rust-lang#75080
@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc
r? @jyn514
couldn't fix these
```rust
../../std/string/struct.String.html
../../std/primitive.never.html
../../std/sync/mpsc/struct.TryIter.html
```
Liballoc extend use intra doc link Superseeds https://github.com/rust-lang/rust/pull/75729/commits r? @jyn514
Add missing hyphen reference counted pointer -> reference-counted pointer @rustbot modify labels: T-doc
…ribute_before_return, r=GuillaumeGomez rust-langGH-66816: Remove disable attr before return Passing --disable-per-crate-search removes the create search inputs so moved code around so that the search input is enabled first before the function returns. Fixes rust-lang#66816
Keep doc standard for Vec DrainFilter r? @jyn514
Use assertions on Vec doc Clarify what the state of Vec after with_capacity on doc. r? @jyn514
Use explicit intra-doc link in path for Vec resize r? @jyn514
Update README.md
Update MinGW instructions to include ninja Rust now requires `ninja` to build, so the MinGW build instructions are updated to reflect this. Like for `python` and `cmake`, the `mingw-w64-x86_64-ninja` package should be used. The default package from the `msys2` subsystem doesn't handle paths correctly on windows.
|
Argh, somehow I did this twice, #76153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost