Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing link in README #76229

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Add missing link in README #76229

merged 1 commit into from
Sep 7, 2020

Conversation

camelid
Copy link
Member

@camelid camelid commented Sep 2, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2020
@jonas-schievink
Copy link
Contributor

@bors r+ rollup

@jyn514
Copy link
Member

jyn514 commented Sep 3, 2020

Looks like bors was confused.

@bors r=jonas-schievink rollup

jyn514
jyn514 reviewed Sep 3, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@camelid
Copy link
Member Author

camelid commented Sep 3, 2020

Hmm, the PR is still not in bors's queue.

@jyn514
Copy link
Member

jyn514 commented Sep 3, 2020

cc @rust-lang/infra - @bors is ignoring pings

@jyn514
Copy link
Member

jyn514 commented Sep 3, 2020

Let's try this again.

@bors r+ rollup

@camelid
Copy link
Member Author

camelid commented Sep 3, 2020

The PR isn't even showing up in the unapproved queue...

@camelid
Copy link
Member Author

camelid commented Sep 3, 2020

Maybe turn it off and turn it back on again? That always seems to do the trick :)

@pietroalbini pietroalbini reopened this Sep 3, 2020
@pietroalbini
Copy link
Member

@bors r=jonas-schievink rollup

@bors
Copy link
Contributor

bors commented Sep 3, 2020

📌 Commit 8783c62 has been approved by jonas-schievink

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2020
@bors
Copy link
Contributor

bors commented Sep 3, 2020

⌛ Testing commit 8783c62 with merge 6cb327806a45b30e4cae4e21be28a7b3b9c665e6...

@bors
Copy link
Contributor

bors commented Sep 3, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 3, 2020
@rust-log-analyzer
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@kennytm
Copy link
Member

kennytm commented Sep 3, 2020

@bors retry

2020-09-03T08:44:49.4142178Z curl: (56) OpenSSL SSL_read: Connection was reset, errno 10054
2020-09-03T08:44:49.4149901Z tar: Unexpected EOF in archive
2020-09-03T08:44:49.4150326Z tar: Unexpected EOF in archive

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2020
@bors
Copy link
Contributor

bors commented Sep 3, 2020

⌛ Testing commit 8783c62 with merge 79db8259d21978752d5abfe5e32f233fbdcc0a35...

matklad added a commit to matklad/rust that referenced this pull request Sep 4, 2020
@matklad
Rollup merge of rust-lang#76229 - camelid:patch-3, r=jonas-schievink
388e04d 
Add missing link in README
@matklad matklad mentioned this pull request Sep 4, 2020
Closed
matklad added a commit to matklad/rust that referenced this pull request Sep 4, 2020
@matklad
Rollup merge of rust-lang#76229 - camelid:patch-3, r=jonas-schievink
1541049 
Add missing link in README
@matklad matklad mentioned this pull request Sep 4, 2020
Closed
matklad added a commit to matklad/rust that referenced this pull request Sep 4, 2020
@matklad
Rollup merge of rust-lang#76229 - camelid:patch-3, r=jonas-schievink
7ab6e80 
Add missing link in README
@matklad matklad mentioned this pull request Sep 4, 2020
Closed
matklad added a commit to matklad/rust that referenced this pull request Sep 4, 2020
@matklad
Rollup merge of rust-lang#76229 - camelid:patch-3, r=jonas-schievink
9567d3e 
Add missing link in README
@matklad matklad mentioned this pull request Sep 4, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 4, 2020
@Dylan-DPC
Rollup merge of rust-lang#76229 - camelid:patch-3, r=jonas-schievink
2ba25e9 
Add missing link in README
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Sep 4, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 4, 2020
@Dylan-DPC
Rollup merge of rust-lang#76229 - camelid:patch-3, r=jonas-schievink
62ffaad 
Add missing link in README
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Sep 4, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 5, 2020
@Dylan-DPC
Rollup merge of rust-lang#76229 - camelid:patch-3, r=jonas-schievink
727c83d 
Add missing link in README
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Sep 5, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 5, 2020
@Dylan-DPC
Rollup merge of rust-lang#76229 - camelid:patch-3, r=jonas-schievink
984e417 
Add missing link in README
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Sep 5, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 5, 2020
@Dylan-DPC
Rollup merge of rust-lang#76229 - camelid:patch-3, r=jonas-schievink
91df663 
Add missing link in README
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Sep 5, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 6, 2020
@Dylan-DPC
Rollup merge of rust-lang#76229 - camelid:patch-3, r=jonas-schievink
de3e0a6 
Add missing link in README
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Sep 6, 2020
Closed
@bors
Copy link
Contributor

bors commented Sep 6, 2020

⌛ Testing commit 8783c62 with merge bf4d6cc...

@bors
Copy link
Contributor

bors commented Sep 7, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: jonas-schievink
Pushing bf4d6cc to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 7, 2020
@bors bors merged commit bf4d6cc into rust-lang:master Sep 7, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 7, 2020
@camelid camelid deleted the patch-3 branch September 7, 2020 00:46
@camelid
Copy link
Member Author

camelid commented Sep 7, 2020

That's cool that rustbot automatically adds milestones! Thanks @Mark-Simulacrum!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@nikomatsakis nikomatsakis

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
10 participants
@camelid @rust-highfive @jonas-schievink @jyn514 @pietroalbini @bors @rust-log-analyzer @kennytm @nikomatsakis @rustbot