Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to #capacity-and-reallocation when using with_capacity #76303

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Sep 3, 2020

Follow up to #76058 (comment).
r? @pickfire

@jyn514 jyn514 added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2020
@Dylan-DPC-zz
Copy link

r? @Dylan-DPC
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 3, 2020

📌 Commit 7b823df has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2020
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but it feels kinda weird to point to the same document.

@jyn514
Copy link
Member Author

jyn514 commented Sep 4, 2020

it feels kinda weird to point to the same document

Like Iterator, Vec is a really big page. So I think adding hyperlinks within the page is helpful to navigate it.

matklad added a commit to matklad/rust that referenced this pull request Sep 4, 2020
Link to `#capacity-and-reallocation` when using with_capacity

Follow up to rust-lang#76058 (comment).
r? @pickfire
matklad added a commit to matklad/rust that referenced this pull request Sep 4, 2020
Link to `#capacity-and-reallocation` when using with_capacity

Follow up to rust-lang#76058 (comment).
r? @pickfire
matklad added a commit to matklad/rust that referenced this pull request Sep 4, 2020
Link to `#capacity-and-reallocation` when using with_capacity

Follow up to rust-lang#76058 (comment).
r? @pickfire
matklad added a commit to matklad/rust that referenced this pull request Sep 4, 2020
Link to `#capacity-and-reallocation` when using with_capacity

Follow up to rust-lang#76058 (comment).
r? @pickfire
matklad added a commit to matklad/rust that referenced this pull request Sep 4, 2020
Link to `#capacity-and-reallocation` when using with_capacity

Follow up to rust-lang#76058 (comment).
r? @pickfire
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 6, 2020
Link to `#capacity-and-reallocation` when using with_capacity

Follow up to rust-lang#76058 (comment).
r? @pickfire
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 7, 2020
Rollup of 18 pull requests

Successful merges:

 - rust-lang#76273 (Move some Vec UI tests into alloc unit tests)
 - rust-lang#76274 (Allow try blocks as the argument to return expressions)
 - rust-lang#76287 (Remove an unnecessary allowed lint)
 - rust-lang#76293 (Implementation of incompatible features error)
 - rust-lang#76299 (Make `Ipv4Addr` and `Ipv6Addr` const tests unit tests under `library`)
 - rust-lang#76302 (Address review comments on `Peekable::next_if`)
 - rust-lang#76303 (Link to `#capacity-and-reallocation` when using with_capacity)
 - rust-lang#76305 (Move various ui const tests to `library`)
 - rust-lang#76309 (Indent a note to make folding work nicer)
 - rust-lang#76312 (time.rs: Make spelling of "Darwin" consistent)
 - rust-lang#76318 (Use ops::ControlFlow in rustc_data_structures::graph::iterate)
 - rust-lang#76324 (Move Vec slice UI tests in library)
 - rust-lang#76338 (add some intra-doc links to `Iterator`)
 - rust-lang#76340 (Remove unused duplicated `trivial_dropck_outlives`)
 - rust-lang#76344 (Improve docs for `std::env::args()`)
 - rust-lang#76346 (Docs: nlink example typo)
 - rust-lang#76358 (Minor grammar fix in doc comment for soft-deprecated methods)
 - rust-lang#76364 (Disable atomics on avr target.)

Failed merges:

 - rust-lang#76304 (Make delegation methods of `std::net::IpAddr` unstably const)

r? @ghost
@bors bors merged commit 5b8f76d into rust-lang:master Sep 7, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 7, 2020
@jyn514 jyn514 deleted the vec-assert-doc branch September 12, 2020 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants