-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[experiment] rustc_mir: remove #![type_length_limit]
checks.
#76772
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 688ec8c with merge dd5d681da665963dde4cc4561bcfc4d348beb75b... |
☀️ Try build successful - checks-actions, checks-azure |
Queued dd5d681da665963dde4cc4561bcfc4d348beb75b with parent 6af1bdd, future comparison URL. |
Finished benchmarking try commit (dd5d681da665963dde4cc4561bcfc4d348beb75b): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
So 1% at best, and only on Perhaps we could test further on some of the reported regressions? |
@eddyb It appears there are merge conflicts. |
So chalk uses a type-length limit test but in a different way. Instead of forbidding types completely, it "just" causes trait solving to yield ambiguous results when types are getting too big. |
Closing this as it's a super old experiment |
The first time we started doubting the usefulness of this check was in #54540, but it's been showing up more.
I've since learned that the PR which added this (#37789) did fix a real issue (#37311) but IMO it's not the most efficient solution (we could instead e.g. periodically warn that monomorphization collection is still ongoing, and that it could indicate an accidental generic blowup), though we may not have anything better in general.
Nevertheless, I think it's a good idea to try this out, even if it may be too late for certain regressions.
This PR was specifically prompted by @hawkw running into a slowdown which may be caused by the
#![type_length_limit]
check, but we don't really know much for certain yet (and a try build is the easiest comparison that has some guarantees of fairness, plus we can get the perf run results).cc @nikomatsakis @pnkfelix @arielb1 @lcnr