Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mir-opt] Disable the ConsideredEqual logic in SimplifyBranchSame opt #76837

Merged
merged 1 commit into from
Sep 18, 2020
Merged

[mir-opt] Disable the ConsideredEqual logic in SimplifyBranchSame opt #76837

merged 1 commit into from
Sep 18, 2020

Conversation

wesleywiser
Copy link
Member

The logic is currently broken and we need to disable it to fix a beta
regression (see #76803)

r? @oli-obk

@wesleywiser wesleywiser added beta-nominated Nominated for backporting to the compiler in the beta channel. A-mir-opt Area: MIR optimizations labels Sep 17, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 17, 2020
@wesleywiser
[mir-opt] Disable the ConsideredEqual logic in SimplifyBranchSame opt
dbd7226 
The logic is currently broken and we need to disable it to fix a beta
regression (see rust-lang#76803)
@wesleywiser wesleywiser force-pushed the disable_consideredequal branch from e40e4eb to dbd7226 Compare September 17, 2020 13:37
@jonas-schievink jonas-schievink added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 17, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Sep 17, 2020

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Sep 17, 2020

📌 Commit dbd7226 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2020
@bors
Copy link
Contributor

bors commented Sep 17, 2020

⌛ Testing commit dbd7226 with merge a4b89bbf799a0e26b22994dd8fb46ac664c2678b...

@simonvandel simonvandel mentioned this pull request Sep 17, 2020
Merged
@bors
Copy link
Contributor

bors commented Sep 17, 2020

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 17, 2020
@rust-log-analyzer
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
##[group]Run exit 1
exit 1
shell: /bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
##[error]Process completed with exit code 1.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@wesleywiser
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2020
@bors
Copy link
Contributor

bors commented Sep 18, 2020

⌛ Testing commit dbd7226 with merge 7298f74325871e387d72e4d512a1600c7104c5e3...

@bors
Copy link
Contributor

bors commented Sep 18, 2020

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 18, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Sep 18, 2020

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2020
@bors
Copy link
Contributor

bors commented Sep 18, 2020

⌛ Testing commit dbd7226 with merge 2c69266...

@bors
Copy link
Contributor

bors commented Sep 18, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: oli-obk
Pushing 2c69266 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 18, 2020
@bors bors merged commit 2c69266 into rust-lang:master Sep 18, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 18, 2020
@spastorino
Copy link
Member

discussed in T-compiler meeting.

@rustbot modify labels: beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Sep 24, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 25, 2020
@bors
Auto merge of rust-lang#76844 - simonvandel:fix-76803, r=wesleywiser
9d74efe 
Fix rust-lang#76803 miscompilation

Fixes rust-lang#76803
Seems like it was an oversight that the discriminant value being set was not compared to the target value from the SwitchInt, as a comment says this is a requirement for the optimization to be sound.

r? `@wesleywiser` since you are probably familiar with the optimization and made rust-lang#76837 to workaround the bug
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.48.0, 1.47.0 Sep 28, 2020
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 28, 2020
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 28, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 29, 2020
@bors
Auto merge of rust-lang#77308 - Mark-Simulacrum:beta-next, r=Mark-Sim…
9f0e6fa 
…ulacrum

[beta] backports

This backports the following:
 *  revert const_type_id stabilization rust-lang#77083
 * [mir-opt] Disable the `ConsideredEqual` logic in SimplifyBranchSame opt rust-lang#76837
 * Rename Iterator::get_unchecked rust-lang#77201 (manually, because of file renaming and other issues on master causing literal cherry-pick to fail)
 *  Rebase LLVM onto 11.0.0-rc3 rust-lang#77063 (bumping direct to master, see rust-lang#77063 (comment)).

The last two have not yet been approved by compiler team, but I'm posting this now and going to go ahead and approve as I expect both to get approved and we want testing as much as possible before release in ~2 weeks.

r? `@ghost`
@wesleywiser wesleywiser mentioned this pull request Sep 30, 2020
Closed
@SNCPlay42 SNCPlay42 mentioned this pull request Apr 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

@RalfJung RalfJung RalfJung left review comments

@pnkfelix pnkfelix pnkfelix left review comments

Assignees

@oli-obk oli-obk

Labels
A-mir-opt Area: MIR optimizations beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.