Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Do not make local copies of inline(always) fns in debug mode #76889

Closed
wants to merge 1 commit into from
Closed

[WIP] Do not make local copies of inline(always) fns in debug mode #76889

wants to merge 1 commit into from

Conversation

spastorino
Copy link
Member

r? @wesleywiser

cc @rust-lang/wg-incr-comp

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2020
@spastorino
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Sep 18, 2020

⌛ Trying commit 7ddcdd2431be8bd226fd806d3364c61e422a9512 with merge 27353323388ee6b69b9bba1ec551b0de67e79098...

@spastorino spastorino changed the title Do not make local copy of inline(always) fns in debug mode Do not make local copies of inline(always) fns in debug mode Sep 18, 2020
@bors
Copy link
Contributor

bors commented Sep 18, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 27353323388ee6b69b9bba1ec551b0de67e79098 (27353323388ee6b69b9bba1ec551b0de67e79098)

@rust-timer
Copy link
Collaborator

Queued 27353323388ee6b69b9bba1ec551b0de67e79098 with parent fdc3405, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (27353323388ee6b69b9bba1ec551b0de67e79098): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@spastorino spastorino force-pushed the codegen-inline-fns1 branch 2 times, most recently from 4bf6df8 to f0e2988 Compare September 18, 2020 19:55
@spastorino spastorino mentioned this pull request Sep 18, 2020
Merged
@spastorino spastorino changed the title Do not make local copies of inline(always) fns in debug mode [WIP] Do not make local copies of inline(always) fns in debug mode Sep 19, 2020
@spastorino
Copy link
Member Author

Closing in favor of #76896

@spastorino spastorino closed this Sep 22, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2021
@bors
Auto merge of rust-lang#76896 - spastorino:codegen-inline-fns2, r=dav…
ddf2cc7 
…idtwco,wesleywiser

Do not make local copies of inline fns in debug mode

r? `@wesleywiser`

cc `@rust-lang/wg-incr-comp`

If this is correct it supersedes rust-lang#76889

Related to rust-lang#54089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wesleywiser wesleywiser

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spastorino @rust-timer @bors @wesleywiser @rust-highfive