-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stability annotations on generic parameters (take 2.5) #77118
Stability annotations on generic parameters (take 2.5) #77118
Conversation
Co-authored-by: Tim Diekmann <21277928+TimDiekmann@users.noreply.github.com>
Co-authored-by: varkor <github@varkor.com>
Co-authored-by: varkor <github@varkor.com>
Co-authored-by: varkor <github@varkor.com>
Co-authored-by: varkor <github@varkor.com>
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks for taking this across the finish line! @bors r+ |
📌 Commit 98eab09 has been approved by |
Thanks to @Avi-D-coder for all their hard work implementing this feature! |
☀️ Test successful - checks-actions, checks-azure |
Support custom allocators in `Box` r? `@Amanieu` This pull request requires a crater run. ### Prior work: - rust-lang#71873 - rust-lang#58457 - [`alloc-wg`](https://github.com/TimDiekmann/alloc-wg)-crate Currently blocked on: - ~rust-lang#77118~ - ~rust-lang/chalk#615 (rust-lang#77515)~
When adding an unstable generic parameter to
Is this a bug in this implementation or is this a false positive of the compiler when searching for stability annotations? |
Rebase of #72314 + more tests
Implements rust-lang/wg-allocators#2.