-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc_metadata: Do not forget to encode inherent impls for foreign types #77375
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
rustc_metadata: Do not forget to encode inherent impls for foreign types
- Loading branch information
commit 384eb2691f53bb0cdeb17a5ccf73c83e861d9aa1
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
#![feature(extern_types)] | ||
|
||
extern "C" { | ||
pub type CrossCrate; | ||
} | ||
|
||
impl CrossCrate { | ||
pub fn foo(&self) {} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,26 @@ | ||
// run-pass | ||
#![allow(dead_code)] | ||
// Test that inherent impls can be defined for extern types. | ||
|
||
// check-pass | ||
// aux-build:extern-types-inherent-impl.rs | ||
|
||
#![feature(extern_types)] | ||
|
||
extern { | ||
type A; | ||
extern crate extern_types_inherent_impl; | ||
use extern_types_inherent_impl::CrossCrate; | ||
|
||
extern "C" { | ||
type Local; | ||
} | ||
|
||
impl A { | ||
fn foo(&self) { } | ||
impl Local { | ||
fn foo(&self) {} | ||
} | ||
|
||
fn use_foo(x: &A) { | ||
fn use_foo(x: &Local, y: &CrossCrate) { | ||
Local::foo(x); | ||
x.foo(); | ||
CrossCrate::foo(y); | ||
y.foo(); | ||
} | ||
|
||
fn main() { } | ||
fn main() {} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably deduplicate the extern item/regular item encoding logic (well, the parts that are shared between them). While I think this would be good to have, you can r=me this PR and just open an E-easy issue for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made an issue - #77393.