Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #77557

Merged
merged 44 commits into from
Oct 5, 2020
Merged

Rollup of 11 pull requests #77557

merged 44 commits into from
Oct 5, 2020

Commits on Aug 30, 2020

  1. Remove error message in specific case

    In the case that a trait is not implemented for an ADT with type errors, cancel the error.
    JulianKnodt committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    8894b36 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. Configuration menu
    Copy the full SHA
    badf4af View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. Configuration menu
    Copy the full SHA
    e05e2f9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d4928ad View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6e15975 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. Configuration menu
    Copy the full SHA
    df76cf8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0375ee8 View commit details
    Browse the repository at this point in the history
  3. build-manifest: calculate checksums lazily and in parallel

    This commit improves the way build-manifest calculates the checksums
    included in the manifest, speeding it up:
    
    * Instead of calculating all the hashes beforehand and then using the
      ones we need, the manifest is first generated with placeholder hashes,
      and then a function walks through the manifest and calculates only the
      needed checksums.
    
    * Calculating the checksums is now done in parallel with rayon, to
      better utilize all the available disk bandwidth.
    
    * Calculating the checksums now uses the sha2 crate instead of the
      sha256sum CLI tool: this avoids the overhead of calling another
      process, but more importantly uses hardware acceleration whenever
      available (the CLI tool doesn't support it at all).
    pietroalbini committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    acd8e59 View commit details
    Browse the repository at this point in the history
  4. build-manifest: avoid collecting SHAs in parallel on legacy mode

    This avoids overloading the old server, and disrupting the other
    programs running on it.
    pietroalbini committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    fde1135 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9352062 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. Configuration menu
    Copy the full SHA
    0801263 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1db05e0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d71d13e View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2020

  1. Configuration menu
    Copy the full SHA
    488b759 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    96eb68b View commit details
    Browse the repository at this point in the history
  3. Add tests for const_generics

    varkor committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    3631d29 View commit details
    Browse the repository at this point in the history
  4. Move tests

    varkor committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    7029065 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6647eee View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0e68e1b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5c836e3 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0e18017 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3950a6d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6ec2474 View commit details
    Browse the repository at this point in the history
  11. Allow Abort terminators in a const-context

    These appear along the cleanup path inside functions with
    `#[unwind(aborts)]`. We don't const-check the cleanup path anyways,
    since const-eval already has "abort-on-panic" semantics and there's
    often drops that would otherwise be forbidden, so the check wasn't
    really preventing anything anyways.
    ecstatic-morse committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    98a2292 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    a5f0831 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    14c3705 View commit details
    Browse the repository at this point in the history
  14. Replace some once(x).chain(once(y)) with [x, y] IntoIter

    Now that we have by-value array iterators...
    scottmcm committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    d74b8e0 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2020

  1. Configuration menu
    Copy the full SHA
    3641a37 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4585c22 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    25fdbaf View commit details
    Browse the repository at this point in the history
  4. Add comment to Abort match arm

    Co-authored-by: Ralf Jung <post@ralfj.de>
    ecstatic-morse and RalfJung authored Oct 4, 2020
    Configuration menu
    Copy the full SHA
    fe97990 View commit details
    Browse the repository at this point in the history
  5. But whatever

    ecstatic-morse authored Oct 4, 2020
    Configuration menu
    Copy the full SHA
    6ae1da3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    17d3c0a View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2020

  1. Rollup merge of rust-lang#75853 - LeSeulArtichaut:core-intra-docs-3, …

    …r=jyn514
    
    Use more intra-doc-links in `core::fmt`
    
    This is a follow-up to rust-lang#75819, which encountered some broken links due to rust-lang#75176, so this PR contains the links that are blocked on rust-lang#75176.
    
    r? @jyn514
    Dylan-DPC authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    6c9e857 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#75928 - JulianKnodt:non_utf8, r=estebank

    Remove trait_selection error message in specific case
    
    In the case that a trait is not implemented for an ADT with type errors, cancel the error.
    
    Fixes rust-lang#75627
    Dylan-DPC authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    5fa978f View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#76329 - GuillaumeGomez:doc-alias-crate-leve…

    …l, r=matthewjasper
    
    Add check for doc alias attribute at crate level
    
    Fixes rust-lang#76298, rust-lang#64734, rust-lang#69365.
    
    r? @ollie27
    Dylan-DPC authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    e6e7ccc View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#77219 - mightyiam:issue_77100, r=jyn514

    core::global_allocator docs link to std::alloc::GlobalAlloc
    
    Closes rust-lang#77100
    Dylan-DPC authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    583269d View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#77395 - ssomers:btree_love_the_leaf_edge_co…

    …mments, r=Mark-Simulacrum
    
    BTreeMap: admit the existence of leaf edges in comments
    
    The btree code is ambiguous about leaf edges (i.e., edges within leaf nodes). Iteration relies on them heavily, but some of the comments suggest there are no leaf edges (extracted from rust-lang#77025)
    
    r? @Mark-Simulacrum
    Dylan-DPC authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    fe087ec View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#77407 - pietroalbini:less-build-manifest, r…

    …=Mark-Simulacrum
    
    Improve build-manifest to work with the improved promote-release
    
    This PR makes some changes to build-manifest to have it work better with the other improvements I'm making to [promote-release](https://github.com/rust-lang/promote-release).
    
    A new way to invoke the tool was added: `./x.py run src/tools/build-manifest`. The new invocation disables the generation of `.sha256` files and the generation of GPG signatures, as those steps are not tied to the Rust version we're building the manifest of: handling them in `promote-release` will improve the maintenability of our release process. Invocations through the old command (`./x.py dist hash-and-sign`) are referred inside the source code as "legacy". The new invocation also enables internal parallelism, disabled on legacy to avoid overloading our old server.
    
    Improvements were also made on how the checksums included in the manifest are generated:
    
    * The manifest is first generated with placeholder checksums, and then a function walks through the manifes and calculates only the needed hashes. Before this PR, all the hashes were calculated beforehand, including the hashes of unused files.
    * Calculating the hashes is now done in parallel with rayon, to better utilize all the available disk bandwidth.
    * The `sha2` crate is now used instead of the `sha256sum` CLI tool: this avoids the overhead of calling another process, but more importantly enables hardware acceleration whenever available (the `sha256sum` CLI tool doesn't support it at all).
    
    r? @Mark-Simulacrum
    This PR is best reviewed commit-by-commit.
    Dylan-DPC authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    fffeaa7 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#77426 - tamird:sockaddr-scope-id, r=dtolnay

    Include scope id in SocketAddrV6::Display
    
    r? @tmandry
    
    I couldn't find any unit tests for these functions.
    
    cc @ghanan94 @brunowonka
    Dylan-DPC authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    f1afed5 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#77439 - varkor:min_const_generics-tests, r=…

    …lcnr,estebank
    
    Fix missing diagnostic span for `impl Trait` with const generics, and add various tests for `min_const_generics` and `const_generics`
    
    Closes rust-lang#61410.
    
    Adds `min_const_generics` tests for:
    - rust-lang#73727
    - rust-lang#72293
    - rust-lang#67375
    - rust-lang#75153
    - rust-lang#71922
    - rust-lang#69913
    - rust-lang#67945
    - rust-lang#69239
    
    Adds `const_generics` tests for:
    - rust-lang#67375
    - rust-lang#75153
    - rust-lang#71922
    - rust-lang#69913
    - rust-lang#67945
    - rust-lang#69239
    
    (I only added separate `min_const_generics` and `const_generics` tests if they were handled differently by the two features.)
    
    We need to figure out how to deduplicate when `const_generics` is stabilised, but we can discuss that later. For now, we should be checking neither feature breaks, so require regression tests for both. I've given them identical names when I've added both, which should make it easier to spot them later.
    
    r? @lcnr
    Dylan-DPC authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    e032bb7 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#77471 - ssomers:btree_cleanup_3, r=Mark-Sim…

    …ulacrum
    
    BTreeMap: refactoring around edges, missed spots
    
    Tweaks from rust-lang#77244 (and more) that are really inconsistencies in rust-lang#77005.
    
    r? @Mark-Simulacrum
    Dylan-DPC authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    23b1e3d View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#77512 - ecstatic-morse:const-checking-allow…

    …-abort, r=RalfJung
    
    Allow `Abort` terminators in all const-contexts
    
    We never unwind during const-eval, so we basically have these semantics already. Also I just figured out that these only appear along the cleanup path, which doesn't get const-checked. In other words, this doesn't actually change behavior: the `check-pass` test I added compiles just fine on nightly.
    
    r? @RalfJung
    cc @rust-lang/wg-const-eval
    Dylan-DPC authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    5fbb411 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#77514 - scottmcm:less-once-chain-once, r=es…

    …tebank
    
    Replace some once(x).chain(once(y)) with [x, y] IntoIter
    
    Now that we have by-value array iterators that are [already used](https://github.com/rust-lang/rust/blob/25c8c53dd994acb3f4f7c02fe6bb46076393f8b0/compiler/rustc_hir/src/def.rs#L305-L307)...
    
    For example,
    ```diff
    -        once(self.type_ns).chain(once(self.value_ns)).chain(once(self.macro_ns)).filter_map(|it| it)
    +        IntoIter::new([self.type_ns, self.value_ns, self.macro_ns]).filter_map(|it| it)
    ```
    Dylan-DPC authored Oct 5, 2020
    Configuration menu
    Copy the full SHA
    9dbc9ed View commit details
    Browse the repository at this point in the history