Rollup of 8 pull requests #77723
Merged
Rollup of 8 pull requests #77723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
Explain when you should use it and when you should not.
…rk-Simulacrum Don't discourage implementing `core::fmt::Write` Fixes #76729. Explain when you should use it and when you should not.
…-Simulacrum BTreeMap: comment why drain_filter's size_hint is somewhat pessimistic The `size_hint` of the `DrainFilter` iterator doesn't adjust as you iterate. This hardly seems important to me, but there has been a comparable PR #64383 in the past. I guess a scenario is that you first iterate half the map manually and keep most of the key/value pairs in the map, and then tell the predicate to drain most of the key/value pairs and `.collect` the iterator over the remaining half of the map. I am totally ambivalent whether this is better or not. r? @Mark-Simulacrum
(docs): make mutex error comment consistent with codebase Although exceptionally minor, I found this stands out from other error reporting language used in doc comments. With the existence of the `failure` crate, I suppose this could be slightly ambiguous. In any case, this change brings the particular comment into a consistent state with other mentions of returning errors.
…afe, r=Aaron1011 Add compile fail test for issue 27675 A recently merged PR (#73905) strengthened the checks on bounds of associated items. This rejects the attack path of #27675 which consisted of constructing a `dyn Trait<Item=T>` where `T` would not fulfill the bounds required on `Item` of the `Trait` behind the dyn object. This regression test, extracted from [the weaponized instance](#27675 (comment)), checks that this is rejected.
Remove unnecessary lamda on emitter map.
Make `max_log_info` easily greppable (for figuring out why debug logging is disabled) Follow-up to #77678 (comment). I'll make a PR to the dev-guide shortly changing `debug = true` to `debug-logging = true` and using this text. Ideally wouldn't be merged before #77678, but it practice it won't hurt anything. r? @Mark-Simulacrum
Remove not needed lambda.
Update submodule llvm to get LVI bugfix
The LLVM LVI mitigations used register %rcs as a clobber register. This is problematic when rust uses this register to return (part of) function values. The problem was fixed upstream in:
https://reviews.llvm.org/D88924
https://reviews.llvm.org/D88925
PR rust-lang/llvm-project#79 merged it in the llvm_project. This PR updates the submodule
Bug report: https://bugs.llvm.org/show_bug.cgi?id=47740
Fixes #77607
cc: @jethrogb
|
📌 Commit d252848 has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
core::fmt::Write#76750 (Don't discourage implementingcore::fmt::Write)max_log_infoeasily greppable (for figuring out why debug logging is disabled) #77701 (Makemax_log_infoeasily greppable (for figuring out why debug logging is disabled))Failed merges:
r? @ghost