Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Assume slice len is bounded by allocation size" #77771

Merged
merged 1 commit into from
Oct 10, 2020
Merged

Revert "Assume slice len is bounded by allocation size" #77771

merged 1 commit into from
Oct 10, 2020

Conversation

nagisa
Copy link
Member

@nagisa nagisa commented Oct 9, 2020

#77023 (comment)
suggests that the original PR introduced a significant perf regression.

This reverts commit e44784b / #77023.

cc @HeroicKatora

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2020
@nagisa
Copy link
Member Author

nagisa commented Oct 9, 2020

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

r=me, but looks like other stuff started using the features so we'll need to retain them

@nagisa
Revert "Assume slice len is bounded by allocation size"
54a5608 
rust-lang#77023 (comment)
suggests that the original PR introduced a significant perf regression.

This reverts commit e44784b / rust-lang#77023.
@nagisa
Copy link
Member Author

nagisa commented Oct 9, 2020

Huh, I force pushed but github is taking its time catching it...

@nagisa
Copy link
Member Author

nagisa commented Oct 9, 2020

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Oct 9, 2020

📌 Commit 54a5608 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 9, 2020
@camelid camelid added A-slice Area: `[T]` T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Oct 10, 2020
@bors
Copy link
Contributor

bors commented Oct 10, 2020

⌛ Testing commit 54a5608 with merge 87b71ed...

@bors
Copy link
Contributor

bors commented Oct 10, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing 87b71ed to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 10, 2020
@bors bors merged commit 87b71ed into rust-lang:master Oct 10, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 10, 2020
@Mark-Simulacrum
Copy link
Member

perf results on landing are about as expected; a small win. There are some regressions too but nothing too large and on recently-added benchmarks. I would not worry about them right now.

  • Moderate improvement in instruction counts (up to -2.5% on incr-patched: Job builds of regex-opt)
  • Moderate regression in instruction counts (up to 1.3% on full builds of match-stress-enum-check)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Awaiting requested review from Mark-Simulacrum

@ecstatic-morse ecstatic-morse Awaiting requested review from ecstatic-morse

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-slice Area: `[T]` merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
7 participants
@nagisa @rust-highfive @Mark-Simulacrum @bors @kennytm @camelid @rustbot