Simplify a nested bool match #77888
Merged
Simplify a nested bool match #77888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Logically this first eliminates the innermost match by merging the patterns. Then, in a second step, turns the newly innermost match into a `matches!` call.
LingMan
force-pushed
the
ast_pretty_tt_prepend_space
branch
from
4882ad5
to
fcec76b
Compare
|
@bors r+ rollup |
|
📌 Commit fcec76b has been approved by |
bors
added
S-waiting-on-bors
jyn514
added
C-cleanup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 30, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#77334 (Reorder benches const variable) - rust-lang#77888 (Simplify a nested bool match) - rust-lang#77921 (f64: Refactor collapsible_if) - rust-lang#78523 (Revert invalid `fn` return type parsing change) - rust-lang#78524 (Avoid BorrowMutError with RUSTC_LOG=debug) - rust-lang#78545 (Make anonymous binders start at 0) - rust-lang#78554 (Improve wording of `core::ptr::drop_in_place` docs) - rust-lang#78556 (Link to pass docs from NRVO module docs) Failed merges: - rust-lang#78424 (Fix some more clippy warnings) r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logically this first eliminates the innermost match by merging the patterns.
Then, in a second step, turns the newly innermost match into a
matches!call.