Fix grammar in note for orphan-rule error [E0210] #78043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
thanks! @bors r+ rollup |
|
📌 Commit 786e3ea has been approved by |
bors
added
S-waiting-on-bors
camelid
added
A-diagnostics
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 17, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#75802 (resolve: Do not put nonexistent crate `meta` into prelude) - rust-lang#76607 (Modify executable checking to be more universal) - rust-lang#77851 (BTreeMap: refactor Entry out of map.rs into its own file) - rust-lang#78043 (Fix grammar in note for orphan-rule error [E0210]) - rust-lang#78048 (Suggest correct place to add `self` parameter when inside closure) - rust-lang#78050 (Small CSS cleanup) - rust-lang#78059 (Set `MDBOOK_OUTPUT__HTML__INPUT_404` on linkchecker) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the grammar in the error note for [E0210] from:
"= note: implementing a foreign trait is only possible if at least one of the types for which is it implemented is local"
to:
"= note: implementing a foreign trait is only possible if at least one of the types for which it is implemented is local"
The content of this commit is the result of running the following command at the repository root:
find . \( -type d -name .git -prune \) -o -type f -print0 | xargs -0 sed -i 's/which is it implemented/which it is implemented/g'