Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIR validation should check SwitchInt values are valid for the type #78085

Merged
merged 1 commit into from
Oct 25, 2020
Merged

MIR validation should check SwitchInt values are valid for the type #78085

merged 1 commit into from
Oct 25, 2020

Conversation

wesleywiser
Copy link
Member

Fixes #75440

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2020
oli-obk
oli-obk reviewed Oct 20, 2020
View reviewed changes
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit

compiler/rustc_mir/src/transform/validate.rs Outdated Show resolved Hide resolved
compiler/rustc_mir/src/transform/validate.rs Show resolved Hide resolved
@oli-obk
Copy link
Contributor

oli-obk commented Oct 20, 2020

@bors rollup

@wesleywiser wesleywiser force-pushed the mir_validation_switch_int branch from 1a5c915 to dd683e5 Compare October 24, 2020 20:02
@wesleywiser
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Oct 24, 2020

📌 Commit dd683e5 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2020
@JohnTitor JohnTitor mentioned this pull request Oct 25, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 25, 2020
@bors
Auto merge of rust-lang#78350 - JohnTitor:rollup-vbbm5wf, r=JohnTitor
f392479 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#77984 (Compute proper module parent during resolution)
 - rust-lang#78085 (MIR validation should check `SwitchInt` values are valid for the type)
 - rust-lang#78208 (replace `#[allow_internal_unstable]` with `#[rustc_allow_const_fn_unstable]` for `const fn`s)
 - rust-lang#78209 (Update `compiler_builtins` to 0.1.36)
 - rust-lang#78276 (Bump backtrace-rs to enable Mach-O support on iOS.)
 - rust-lang#78320 (Link to cargo's `build-std` feature instead of `xargo` in custom target docs)
 - rust-lang#78322 (BTreeMap: stop mistaking node::MIN_LEN for a node level constraint)
 - rust-lang#78326 (Split out statement attributes changes from rust-lang#78306)

Failed merges:

r? `@ghost`
@bors bors merged commit dbdc61f into rust-lang:master Oct 25, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.

-Zvalidate-mir should check that SwitchInt values are valid for their type
5 participants
@wesleywiser @rust-highfive @oli-obk @bors @rustbot