-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow creating a list of files shipped in a release #78196
Conversation
To expand a bit on what the outcome of this effort is, this is a diff from the list of files shipped today and the ones that are not referenced in the manifest: - build-manifest-nightly-x86_64-unknown-linux-gnu.tar.gz
- build-manifest-nightly-x86_64-unknown-linux-gnu.tar.xz
cargo-nightly-x86_64-unknown-linux-gnu.tar.gz
cargo-nightly-x86_64-unknown-linux-gnu.tar.xz
channel-rust-nightly-date.txt
channel-rust-nightly-git-commit-hash.txt
channel-rust-nightly.toml
clippy-nightly-x86_64-unknown-linux-gnu.tar.gz
clippy-nightly-x86_64-unknown-linux-gnu.tar.xz
- cpu-dist-x86_64-linux.csv
- image-dist-x86_64-linux.txt
llvm-tools-nightly-x86_64-unknown-linux-gnu.tar.gz
llvm-tools-nightly-x86_64-unknown-linux-gnu.tar.xz
miri-nightly-x86_64-unknown-linux-gnu.tar.gz
miri-nightly-x86_64-unknown-linux-gnu.tar.xz
rls-nightly-x86_64-unknown-linux-gnu.tar.gz
rls-nightly-x86_64-unknown-linux-gnu.tar.xz
rust-analysis-nightly-x86_64-unknown-linux-gnu.tar.gz
rust-analysis-nightly-x86_64-unknown-linux-gnu.tar.xz
rust-analyzer-nightly-x86_64-unknown-linux-gnu.tar.gz
rust-analyzer-nightly-x86_64-unknown-linux-gnu.tar.xz
rustc-dev-nightly-x86_64-unknown-linux-gnu.tar.gz
rustc-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
rustc-docs-nightly-x86_64-unknown-linux-gnu.tar.gz
rustc-docs-nightly-x86_64-unknown-linux-gnu.tar.xz
- rustc-nightly-src.tar.gz
- rustc-nightly-src.tar.xz
rustc-nightly-x86_64-unknown-linux-gnu.tar.gz
rustc-nightly-x86_64-unknown-linux-gnu.tar.xz
- rust-dev-nightly-x86_64-unknown-linux-gnu.tar.gz
- rust-dev-nightly-x86_64-unknown-linux-gnu.tar.xz
rust-docs-nightly-x86_64-unknown-linux-gnu.tar.gz
rust-docs-nightly-x86_64-unknown-linux-gnu.tar.xz
rustfmt-nightly-x86_64-unknown-linux-gnu.tar.gz
rustfmt-nightly-x86_64-unknown-linux-gnu.tar.xz
rust-nightly-x86_64-unknown-linux-gnu.tar.gz
rust-nightly-x86_64-unknown-linux-gnu.tar.xz
rust-src-nightly.tar.gz
rust-src-nightly.tar.xz
rust-std-nightly-x86_64-unknown-linux-gnu.tar.gz
rust-std-nightly-x86_64-unknown-linux-gnu.tar.xz
- toolstates-linux.json Of those, only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
Is there a reason rustc-nightly-src is not included in the manifest already? In the long run I'd prefer that manifests were a 1:1 correspondence to the files we ship, i.e., nothing extra would be included -- beyond maybe internal things (e.g., rust-dev component which currently just contains llvm stuff).
|
bfd2271
to
0ee1e91
Compare
@bors r=Mark-Simulacrum |
📌 Commit 0ee1e91 has been approved by |
☀️ Test successful - checks-actions |
This PR adds the
BUILD_MANIFEST_SHIPPED_FILES_PATH
environment variable tobuild-manifest
, which writes a list of all the files referenced in the manifest to the path defined in the variable. The use for this is forpromote-release
to prune files unused files before publishing a release.This PR does not implement any pruning, it just adds support for it to be implemented in the future on
promote-release
's side.r? @Mark-Simulacrum