Promote aarch64-unknown-linux-gnu to Tier 1 #78228

pietroalbini · 2020-10-22T10:33:07Z

This PR promotes the aarch64-unknown-linux-gnu target to Tier 1, as proposed by RFC 2959:

The aarch64-gnu CI job is moved from auto-fallible to auto.
The platform support documentation is updated, uplifting the target to Tiert 1 with a note about missing stack probes support.
Building the documentation is enabled for the target, as we produce the rust-docs component for all Tier 1 platforms.

src/doc/rustc/src/platform-support.md

pietroalbini · 2020-10-28T14:11:13Z

This is ready to be reviewed. r? @Mark-Simulacrum

@rustbot modify labels: -S-blocked S-waiting-on-author

pietroalbini · 2020-11-03T19:19:23Z

Whelp, applied the wrong label.

@rustbot modify labels: -S-waiting-on-author S-waiting-on-review

bors · 2020-11-05T07:50:05Z

☔ The latest upstream changes (presumably #78754) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

This also adds a note about missing stack probes support, per the discussion on RFC 2959.

pietroalbini · 2020-11-05T10:55:05Z

Rebased. r? @Mark-Simulacrum

Mark-Simulacrum · 2020-11-05T21:17:37Z

@bors r+

🎉

bors · 2020-11-05T21:17:40Z

📌 Commit 874cbb8 has been approved by Mark-Simulacrum

…crum Promote aarch64-unknown-linux-gnu to Tier 1 This PR promotes the `aarch64-unknown-linux-gnu` target to Tier 1, as proposed by [RFC 2959]: * The `aarch64-gnu` CI job is moved from `auto-fallible` to `auto`. * The platform support documentation is updated, uplifting the target to Tiert 1 with a note about missing stack probes support. * Building the documentation is enabled for the target, as we produce the `rust-docs` component for all Tier 1 platforms. [RFC 2959]: rust-lang/rfcs#2959

Rollup of 12 pull requests Successful merges: - rust-lang#77640 (Refactor IntErrorKind to avoid "underflow" terminology) - rust-lang#78026 (Define `fs::hard_link` to not follow symlinks.) - rust-lang#78114 (Recognize `private_intra_doc_links` as a lint) - rust-lang#78228 (Promote aarch64-unknown-linux-gnu to Tier 1) - rust-lang#78345 (Fix handling of item names for HIR) - rust-lang#78437 (BTreeMap: stop mistaking node for an orderly place) - rust-lang#78476 (fix some incorrect aliasing in the BTree) - rust-lang#78674 (inliner: Use substs_for_mir_body) - rust-lang#78748 (Implement destructuring assignment for tuples) - rust-lang#78868 (Fix tab focus on restyled switches) - rust-lang#78878 (Avoid overlapping cfg attributes when both macOS and aarch64) - rust-lang#78882 (Nicer hunk headers for rust files) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

Pkgsrc changes: * Adjust patches, convert tabs to spaces so that tests pass. * Remove patches which are no longer needed (upstream changed) * Minor adjustments for SunOS, e.g. disable stack probes. * Adjust cargo checksum patching accordingly. * Remove commented-out use of PATCHELF on NetBSD, which doesn't work anyway... Upstream changes: Version 1.49.0 (2020-12-31) ============================ Language ----------------------- - [Unions can now implement `Drop`, and you can now have a field in a union with `ManuallyDrop<T>`.][77547] - [You can now cast uninhabited enums to integers.][76199] - [You can now bind by reference and by move in patterns.][76119] This allows you to selectively borrow individual components of a type. E.g. ```rust #[derive(Debug)] struct Person { name: String, age: u8, } let person = Person { name: String::from("Alice"), age: 20, }; // `name` is moved out of person, but `age` is referenced. let Person { name, ref age } = person; println!("{} {}", name, age); ``` Compiler ----------------------- - [Added tier 1\* support for `aarch64-unknown-linux-gnu`.][78228] - [Added tier 2 support for `aarch64-apple-darwin`.][75991] - [Added tier 2 support for `aarch64-pc-windows-msvc`.][75914] - [Added tier 3 support for `mipsel-unknown-none`.][78676] - [Raised the minimum supported LLVM version to LLVM 9.][78848] - [Output from threads spawned in tests is now captured.][78227] - [Change os and vendor values to "none" and "unknown" for some targets][78951] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries ----------------------- - [`RangeInclusive` now checks for exhaustion when calling `contains` and indexing.][78109] - [`ToString::to_string` now no longer shrinks the internal buffer in the default implementation.][77997] - [`ops::{Index, IndexMut}` are now implemented for fixed sized arrays of any length.][74989] Stabilized APIs --------------- - [`slice::select_nth_unstable`] - [`slice::select_nth_unstable_by`] - [`slice::select_nth_unstable_by_key`] The following previously stable methods are now `const`. - [`Poll::is_ready`] - [`Poll::is_pending`] Cargo ----------------------- - [Building a crate with `cargo-package` should now be independently reproducible.][cargo/8864] - [`cargo-tree` now marks proc-macro crates.][cargo/8765] - [Added `CARGO_PRIMARY_PACKAGE` build-time environment variable.] [cargo/8758] This variable will be set if the crate being built is one the user selected to build, either with `-p` or through defaults. - [You can now use glob patterns when specifying packages & targets.][cargo/8752] Compatibility Notes ------------------- - [Demoted `i686-unknown-freebsd` from host tier 2 to target tier 2 support.][78746] - [Macros that end with a semi-colon are now treated as statements even if they expand to nothing.][78376] - [Rustc will now check for the validity of some built-in attributes on enum variants.][77015] Previously such invalid or unused attributes could be ignored. - Leading whitespace is stripped more uniformly in documentation comments, which may change behavior. You read [this post about the changes][rustdoc-ws-post] for more details. - [Trait bounds are no longer inferred for associated types.][79904] Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [rustc's internal crates are now compiled using the `initial-exec` Thread Local Storage model.][78201] - [Calculate visibilities once in resolve.][78077] - [Added `system` to the `llvm-libunwind` bootstrap config option.][77703] - [Added `--color` for configuring terminal color support to bootstrap.][79004] [75991]: rust-lang/rust#75991 [78951]: rust-lang/rust#78951 [78848]: rust-lang/rust#78848 [78746]: rust-lang/rust#78746 [78376]: rust-lang/rust#78376 [78228]: rust-lang/rust#78228 [78227]: rust-lang/rust#78227 [78201]: rust-lang/rust#78201 [78109]: rust-lang/rust#78109 [78077]: rust-lang/rust#78077 [77997]: rust-lang/rust#77997 [77703]: rust-lang/rust#77703 [77547]: rust-lang/rust#77547 [77015]: rust-lang/rust#77015 [76199]: rust-lang/rust#76199 [76119]: rust-lang/rust#76119 [75914]: rust-lang/rust#75914 [74989]: rust-lang/rust#74989 [79004]: rust-lang/rust#79004 [78676]: rust-lang/rust#78676 [79904]: rust-lang/rust#79904 [cargo/8864]: rust-lang/cargo#8864 [cargo/8765]: rust-lang/cargo#8765 [cargo/8758]: rust-lang/cargo#8758 [cargo/8752]: rust-lang/cargo#8752 [`slice::select_nth_unstable`]: https://doc.rust-lang.org/nightly/std/primitive.slice.html#method.select_nth_unstable [`slice::select_nth_unstable_by`]: https://doc.rust-lang.org/nightly/std/primitive.slice.html#method.select_nth_unstable_by [`slice::select_nth_unstable_by_key`]: https://doc.rust-lang.org/nightly/std/primitive.slice.html#method.select_nth_unstable_by_key [`hint::spin_loop`]: https://doc.rust-lang.org/stable/std/hint/fn.spin_loop.html [`Poll::is_ready`]: https://doc.rust-lang.org/stable/std/task/enum.Poll.html#method.is_ready [`Poll::is_pending`]: https://doc.rust-lang.org/stable/std/task/enum.Poll.html#method.is_pending [rustdoc-ws-post]: https://blog.guillaume-gomez.fr/articles/2020-11-11+New+doc+comment+handling+in+rustdoc

tesuji reviewed Oct 22, 2020

View reviewed changes

src/doc/rustc/src/platform-support.md Show resolved Hide resolved

pietroalbini mentioned this pull request Oct 22, 2020

Tracking Issue for RFC 2959: Promote aarch64-unknown-linux-gnu to a Tier-1 Rust target #78251

Closed

2 tasks

rust-highfive assigned Mark-Simulacrum Oct 28, 2020

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 28, 2020

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 3, 2020

pietroalbini added 3 commits November 5, 2020 11:54

ci: gate on aarch64-gnu passing tests

54a0a98

doc/rustc: promote aarch64-unknown-linux-gnu to tier 1

1274fae

This also adds a note about missing stack probes support, per the discussion on RFC 2959.

ci: build docs for aarch64-unknown-linux-gnu

874cbb8

pietroalbini force-pushed the finally branch from 67817af to 874cbb8 Compare November 5, 2020 10:54

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 5, 2020

Dylan-DPC-zz mentioned this pull request Nov 6, 2020

Rollup of 11 pull requests #78792

Closed

Dylan-DPC-zz mentioned this pull request Nov 8, 2020

Rollup of 15 pull requests #78870

Closed

Dylan-DPC-zz mentioned this pull request Nov 8, 2020

Rollup of 12 pull requests #78885

Closed

Dylan-DPC-zz mentioned this pull request Nov 9, 2020

Rollup of 12 pull requests #78889

Merged

bors merged commit 50086af into rust-lang:master Nov 9, 2020

rustbot added this to the 1.49.0 milestone Nov 9, 2020

pietroalbini deleted the finally branch November 9, 2020 10:39

ehuss mentioned this pull request Aug 9, 2024

Promote aarch64-apple-darwin to Tier 1 #128592

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promote aarch64-unknown-linux-gnu to Tier 1 #78228

Promote aarch64-unknown-linux-gnu to Tier 1 #78228

pietroalbini commented Oct 22, 2020 •

edited by Mark-Simulacrum

Loading

pietroalbini commented Oct 28, 2020

pietroalbini commented Nov 3, 2020

bors commented Nov 5, 2020

pietroalbini commented Nov 5, 2020

Mark-Simulacrum commented Nov 5, 2020

bors commented Nov 5, 2020

Promote aarch64-unknown-linux-gnu to Tier 1 #78228

Promote aarch64-unknown-linux-gnu to Tier 1 #78228

Conversation

pietroalbini commented Oct 22, 2020 • edited by Mark-Simulacrum Loading

pietroalbini commented Oct 28, 2020

pietroalbini commented Nov 3, 2020

bors commented Nov 5, 2020

pietroalbini commented Nov 5, 2020

Mark-Simulacrum commented Nov 5, 2020

bors commented Nov 5, 2020

pietroalbini commented Oct 22, 2020 •

edited by Mark-Simulacrum

Loading