Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf] rustc_ast: Remove one level of indirection from LazyTokenStream #78612

Closed
wants to merge 1 commit into from

Conversation

petrochenkov
Copy link
Contributor

It makes Expr and Nonterminal larger due to a fat pointer, but both of those structures live lonely under P and Lrc respectively, so it shouldn't have much effect until the size crosses some power of two boundary, I guess?

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 31, 2020
@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Oct 31, 2020

⌛ Trying commit 575fe58 with merge b92b8916cd0d5b3d43609a51b80c9b35221f663e...

@petrochenkov petrochenkov added S-waiting-on-perf Status: Waiting on a perf run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2020
@bors
Copy link
Contributor

bors commented Oct 31, 2020

☀️ Try build successful - checks-actions
Build commit: b92b8916cd0d5b3d43609a51b80c9b35221f663e (b92b8916cd0d5b3d43609a51b80c9b35221f663e)

@rust-timer
Copy link
Collaborator

Queued b92b8916cd0d5b3d43609a51b80c9b35221f663e with parent 4f7612a, future comparison URL.

@jyn514 jyn514 added A-parser Area: The parsing of Rust source code to an AST I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 31, 2020
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (b92b8916cd0d5b3d43609a51b80c9b35221f663e): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Nov 1, 2020
@varkor
Copy link
Member

varkor commented Nov 1, 2020

Looks like a (minor) regression overall.

@petrochenkov
Copy link
Contributor Author

Yep, looks like it, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-parser Area: The parsing of Rust source code to an AST I-compiletime Issue: Problems and improvements with respect to compile times. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants