-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[perf] rustc_ast: Remove one level of indirection from LazyTokenStream
#78612
Conversation
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 575fe58 with merge b92b8916cd0d5b3d43609a51b80c9b35221f663e... |
☀️ Try build successful - checks-actions |
Queued b92b8916cd0d5b3d43609a51b80c9b35221f663e with parent 4f7612a, future comparison URL. |
Finished benchmarking try commit (b92b8916cd0d5b3d43609a51b80c9b35221f663e): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Looks like a (minor) regression overall. |
Yep, looks like it, closing. |
It makes
Expr
andNonterminal
larger due to a fat pointer, but both of those structures live lonely underP
andLrc
respectively, so it shouldn't have much effect until the size crosses some power of two boundary, I guess?