Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverse binding order in matches to allow the subbinding of copyable fields in bindings after @ #78638

Merged
merged 7 commits into from
Nov 5, 2020
Merged

reverse binding order in matches to allow the subbinding of copyable fields in bindings after @ #78638

merged 7 commits into from
Nov 5, 2020

Conversation

vn-ki
Copy link
Contributor

@vn-ki vn-ki commented Nov 1, 2020 •
edited
Loading

Fixes #69971

TODO

  • Regression tests

r? @oli-obk

@vn-ki
reverse binding order in matches ...
c93d25b 
... to allow the subbinding of copyable fields in bindings after `@`

Fixes rust-lang#69971
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 1, 2020
@vn-ki vn-ki requested a review from oli-obk November 3, 2020 09:29
@oli-obk
Copy link
Contributor

oli-obk commented Nov 3, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Nov 3, 2020

📌 Commit 5827fba has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2020
@oli-obk oli-obk mentioned this pull request Nov 3, 2020
Closed
@oli-obk
Copy link
Contributor

oli-obk commented Nov 3, 2020

cc @matthewjasper

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Nov 3, 2020
@Dylan-DPC
Rollup merge of rust-lang#78638 - vn-ki:bindigs-after-at-issue-69971,…
6a7753e 
… r=oli-obk

reverse binding order in matches to allow the subbinding of copyable fields in bindings after @

Fixes rust-lang#69971

### TODO

- [x] Regression tests

r? `@oli-obk`
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Nov 3, 2020
Closed
@bors
Copy link
Contributor

bors commented Nov 3, 2020

⌛ Testing commit 5827fba with merge 78976a1902a463c21c05aceec3b4f09ddb81df1b...

@bors
Copy link
Contributor

bors commented Nov 4, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 4, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Nov 4, 2020

@bors retry spurious network error

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 4, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 4, 2020
@bors
Copy link
Contributor

bors commented Nov 4, 2020

⌛ Testing commit 5827fba with merge d8f88208b11f8e4d2aab91a239e7d9da152ff363...

@bors
Copy link
Contributor

bors commented Nov 4, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 4, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Nov 4, 2020

I can't tell why that test would fail only on macs. And especially how the changes in this PR could cause them

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2020
@bors
Copy link
Contributor

bors commented Nov 4, 2020

⌛ Testing commit 5827fba with merge 76bca8caf2a1defd171f8329ce8a119cff398037...

@bors
Copy link
Contributor

bors commented Nov 4, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 4, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Nov 4, 2020 

Warning: Failed to download action 'https://api.github.com/repos/actions/checkout/zipball/50fbc622fc4ef5163becd7fab6573eac35f8462e'. Error: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
Warning: Back off 17.33 seconds before retry.
Warning: Failed to download action 'https://api.github.com/repos/actions/checkout/zipball/50fbc622fc4ef5163becd7fab6573eac35f8462e'. Error: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
Warning: Back off 11.692 seconds before retry.
Error: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2020
@bors
Copy link
Contributor

bors commented Nov 4, 2020

⌛ Testing commit 5827fba with merge 8285a26dda9d64e4b1fd0b70afea899812e359f3...

@bors
Copy link
Contributor

bors commented Nov 4, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 4, 2020
@pietroalbini
Copy link
Member

@bors retry #78743

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2020
@bors
Copy link
Contributor

bors commented Nov 5, 2020

⌛ Testing commit 5827fba with merge b1d9f31...

@bors
Copy link
Contributor

bors commented Nov 5, 2020

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing b1d9f31 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 5, 2020
@bors bors merged commit b1d9f31 into rust-lang:master Nov 5, 2020
@rustbot rustbot added this to the 1.49.0 milestone Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk requested changes

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.

Unnecessary 'cannot bind by-move with sub-bindings' with bindings_after_at
6 participants
@vn-ki @rust-highfive @oli-obk @bors @pietroalbini @rustbot