Implement Option::take() #7865

bluss · 2013-07-17T23:55:23Z

Implement Option::take() that replaces the value with None, and returns the Option value as it was.

As mentioned in issue #7764

This operation is a component of .take_unwrap() and a common use of util::replace.

…ossible

bluss · 2013-07-18T00:13:15Z

Redundant with pull #7858

…r=xFrednet Fix `match_str_case_mismatch` on uncased chars False positives would result because `char::is_lowercase` and friends will return `false` for non-alphabetic chars and alphabetic chars lacking case (such as CJK scripts). Care also has to be taken for handling titlecase characters (`ǲ`) and lowercased chars with no uppercase equivalent (`ʁ`). For example, when verifying lowercase: * Check `!any(char::is_ascii_uppercase)` instead of `all(char::is_ascii_lowercase)` for ASCII. * Check that `all(|c| c.to_lowercase() == c)` instead of `all(char::is_lowercase)` for non-ASCII Fixes rust-lang#7863. changelog: Fix false positives in [`match_str_case_mismatch`] on uncased characters

blake2-ppc added 2 commits July 17, 2013 23:48

option: Add .take() to replace value with None and return original value

f0c61c4

This operation is a component of .take_unwrap() and a common use of util::replace.

Use Option .take() or .take_unwrap() instead of util::replace where p…

d7c3d7d

…ossible

bluss closed this Jul 18, 2013

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Option::take() #7865

Implement Option::take() #7865

bluss commented Jul 17, 2013

bluss commented Jul 18, 2013

Implement Option::take() #7865

Implement Option::take() #7865

Conversation

bluss commented Jul 17, 2013

bluss commented Jul 18, 2013