Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Revert "Enable ASLR for windows-gnu" #79141

Closed
wants to merge 1 commit into from
Closed

[beta] Revert "Enable ASLR for windows-gnu" #79141

wants to merge 1 commit into from

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Nov 17, 2020 •
edited
Loading

This reverts commit 0ad3da0.

Per #75406 (comment)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 17, 2020
@jyn514 jyn514 changed the title Revert "Enable ASLR for windows-gnu" [beta] Revert "Enable ASLR for windows-gnu" Nov 17, 2020
@jyn514 jyn514 added A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows O-windows-gnu Toolchain: GNU, Operating system: Windows T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Nov 17, 2020
This was referenced Nov 18, 2020
Merged
Merged
@Mark-Simulacrum Mark-Simulacrum added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Nov 19, 2020
@Mark-Simulacrum
Copy link
Member

(Marking with beta labels though it's targeting beta branch already, I will pick this up in next round of backports).

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2020
@Mark-Simulacrum
Copy link
Member

Included in backport PR going up shortly, closing this.

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Dec 8, 2020
Merged
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 8, 2020
@mati865 mati865 deleted the mingw-beta-revert-aslr branch December 8, 2020 22:06
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 8, 2020
@bors
Auto merge of rust-lang#79838 - Mark-Simulacrum:beta-next, r=Mark-Sim…
19ccb6c 
…ulacrum

[beta] backports

* [beta] always disable copy_file_range to avoid EOVERFLOW errors rust-lang#79008
* Enforce no-move rule of ReentrantMutex using Pin and fix UB in stdio rust-lang#77801
* bootstrap: use the same version number for rustc and cargo rust-lang#79133
* [beta] Revert "Enable ASLR for windows-gnu" rust-lang#79141
* [beta] revert rust-lang#78790, vendor libtest for rustc-src rust-lang#79571
* Mirror centos vault to S3 rust-lang#79435
*  [beta] Update cargo rust-lang#79739

This also bumps to non-dev stable compiler.

r? `@ghost`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows beta-accepted Accepted for backporting to the compiler in the beta channel. O-windows-gnu Toolchain: GNU, Operating system: Windows S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mati865 @rust-highfive @Mark-Simulacrum @jyn514