Stabilize `core::slice::fill` #79213

yoshuawuyts · 2020-11-19T20:42:47Z

Tracking issue #70758

Stabilizes the core::slice::fill API in Rust 1.50, adding a memset doc alias so people coming from C/C++ looking for this operation can find it in the docs. This API hasn't seen any changes since we changed the signature in #71165, and it seems like the right time to propose stabilization. Thanks!

r? @m-ou-se

m-ou-se · 2020-11-19T20:57:29Z

@rfcbot merge

rfcbot · 2020-11-19T20:57:30Z

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

library/core/src/slice/mod.rs

bors · 2020-11-22T07:24:09Z

☔ The latest upstream changes (presumably #79229) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

yoshuawuyts · 2020-12-04T18:50:29Z

I fixed the merge conflicts a few days ago, and CI is passing again. I think the label should be updated again to s-waiting-on-review.

Amanieu · 2020-12-09T01:38:36Z

I think fill_with is also a good candidate to stabilize.

rfcbot · 2020-12-09T12:11:40Z

🔔 This is now entering its final comment period, as per the review above. 🔔

yoshuawuyts · 2020-12-11T15:19:38Z

@Amanieu I'd be happy to put a PR up for that after this lands!

rfcbot · 2020-12-19T12:16:42Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

m-ou-se · 2020-12-19T12:59:56Z

@bors r+ rollup

bors · 2020-12-19T12:59:58Z

📌 Commit 52eade1 has been approved by m-ou-se

…=m-ou-se Stabilize `core::slice::fill` Tracking issue rust-lang#70758 Stabilizes the `core::slice::fill` API in Rust 1.50, adding a `memset` doc alias so people coming from C/C++ looking for this operation can find it in the docs. This API hasn't seen any changes since we changed the signature in rust-lang#71165, and it seems like the right time to propose stabilization. Thanks! r? `@m-ou-se`

…=m-ou-se Stabilize `core::slice::fill` Tracking issue rust-lang#70758 Stabilizes the `core::slice::fill` API in Rust 1.50, adding a `memset` doc alias so people coming from C/C++ looking for this operation can find it in the docs. This API hasn't seen any changes since we changed the signature in rust-lang#71165, and it seems like the right time to propose stabilization. Thanks! r? ``@m-ou-se``

bors · 2020-12-20T10:02:14Z

⌛ Testing commit 52eade1 with merge 8b3b60ca2ef151d4e6951aaf1cb21460b6b29461...

rust-log-analyzer · 2020-12-20T10:06:42Z

The job x86_64-gnu-nopt failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

   Compiling hashbrown v0.9.0
   Compiling miniz_oxide v0.4.0
   Compiling object v0.22.0
   Compiling addr2line v0.14.0
error: the feature `slice_fill` has been stable since 1.50.0 and no longer requires an attribute to enable
    |
    |
307 | #![feature(slice_fill)]
    |
    |
    = note: `-D stable-features` implied by `-D warnings`
error: aborting due to previous error

error: could not compile `std`

bors · 2020-12-20T10:08:50Z

💔 Test failed - checks-actions

yoshuawuyts · 2020-12-21T23:18:20Z

Oops; I forgot to remove the #![feature(slice_fill)] from lib.rs -- fixed it!

m-ou-se · 2020-12-24T15:22:26Z

@bors r+ rollup

bors · 2020-12-24T15:22:28Z

📌 Commit c2281cc has been approved by m-ou-se

Rollup of 11 pull requests Successful merges: - rust-lang#79213 (Stabilize `core::slice::fill`) - rust-lang#79999 (Refactored verbose print into a function) - rust-lang#80160 (Implemented a compiler diagnostic for move async mistake) - rust-lang#80274 (Rename rustc_middle::lint::LintSource) - rust-lang#80280 (Add installation commands to `x` tool README) - rust-lang#80319 (Fix elided lifetimes shown as `'_` on async functions) - rust-lang#80327 (Updated the match with the matches macro) - rust-lang#80330 (Fix typo in simplify_try.rs) - rust-lang#80340 (Don't unnecessarily override attrs for Module) - rust-lang#80342 (Fix typo) - rust-lang#80352 (BTreeMap: make test cases more explicit on failure) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

pthariensflame · 2021-01-01T19:45:01Z

Does this need relnotes?

rust-highfive assigned m-ou-se Nov 19, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 19, 2020

yoshuawuyts mentioned this pull request Nov 19, 2020

Tracking Issue for the slice::fill method #70758

Closed

3 tasks

m-ou-se added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Nov 19, 2020

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Nov 19, 2020

m-ou-se reviewed Nov 19, 2020

View reviewed changes

library/core/src/slice/mod.rs Outdated Show resolved Hide resolved

m-ou-se added A-slice Area: `[T]` and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 19, 2020

pickfire reviewed Nov 20, 2020

View reviewed changes

library/core/src/slice/mod.rs Show resolved Hide resolved

sdroege mentioned this pull request Nov 21, 2020

Add "memset" as doc alias to slice::fill() #79229

Merged

dtolnay mentioned this pull request Nov 22, 2020

rfcbot unchecks checkbox rust-lang/rfcbot-rs#253

Open

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 22, 2020

m-ou-se added S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 4, 2020

rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Dec 9, 2020

rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Dec 9, 2020

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Dec 19, 2020

rfcbot added the to-announce Announce this issue on triage meeting label Dec 19, 2020

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 19, 2020

Dylan-DPC-zz mentioned this pull request Dec 20, 2020

Rollup of 5 pull requests #80212

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 20, 2020

Stabilize core::slice::fill

c2281cc

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2020

Dylan-DPC-zz mentioned this pull request Dec 25, 2020

Rollup of 11 pull requests #80364

Merged

bors merged commit 21d36e0 into rust-lang:master Dec 25, 2020

rustbot added this to the 1.50.0 milestone Dec 25, 2020

yoshuawuyts deleted the stabilize-slice-fill branch December 28, 2020 22:28

spastorino removed the to-announce Announce this issue on triage meeting label Dec 31, 2020

yoshuawuyts mentioned this pull request Jan 15, 2021

Stabilize core::slice::fill_with #81048

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize `core::slice::fill` #79213

Stabilize `core::slice::fill` #79213

yoshuawuyts commented Nov 19, 2020 •

edited by m-ou-se

Loading

m-ou-se commented Nov 19, 2020

rfcbot commented Nov 19, 2020 •

edited by KodrAus

Loading

bors commented Nov 22, 2020

yoshuawuyts commented Dec 4, 2020 •

edited

Loading

Amanieu commented Dec 9, 2020

rfcbot commented Dec 9, 2020

yoshuawuyts commented Dec 11, 2020

rfcbot commented Dec 19, 2020

m-ou-se commented Dec 19, 2020

bors commented Dec 19, 2020

bors commented Dec 20, 2020

rust-log-analyzer commented Dec 20, 2020

bors commented Dec 20, 2020

yoshuawuyts commented Dec 21, 2020

m-ou-se commented Dec 24, 2020

bors commented Dec 24, 2020

pthariensflame commented Jan 1, 2021

Stabilize core::slice::fill #79213

Stabilize core::slice::fill #79213

Conversation

yoshuawuyts commented Nov 19, 2020 • edited by m-ou-se Loading

m-ou-se commented Nov 19, 2020

rfcbot commented Nov 19, 2020 • edited by KodrAus Loading

bors commented Nov 22, 2020

yoshuawuyts commented Dec 4, 2020 • edited Loading

Amanieu commented Dec 9, 2020

rfcbot commented Dec 9, 2020

yoshuawuyts commented Dec 11, 2020

rfcbot commented Dec 19, 2020

m-ou-se commented Dec 19, 2020

bors commented Dec 19, 2020

bors commented Dec 20, 2020

rust-log-analyzer commented Dec 20, 2020

bors commented Dec 20, 2020

yoshuawuyts commented Dec 21, 2020

m-ou-se commented Dec 24, 2020

bors commented Dec 24, 2020

pthariensflame commented Jan 1, 2021

Stabilize `core::slice::fill` #79213

Stabilize `core::slice::fill` #79213

yoshuawuyts commented Nov 19, 2020 •

edited by m-ou-se

Loading

rfcbot commented Nov 19, 2020 •

edited by KodrAus

Loading

yoshuawuyts commented Dec 4, 2020 •

edited

Loading