Consolidate exhaustiveness-related tests #79243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
A-exhaustiveness-checking
rust-highfive
added
the
S-waiting-on-review
Nadrieril
force-pushed
the
consolidate-tests
branch
from
a8b4aa0 to
f51c94e
Compare
Nadrieril
force-pushed
the
consolidate-tests
branch
from
f51c94e to
3213efc
Compare
jyn514
added
A-testsuite
varkor
reviewed
Nov 22, 2020
| match 0usize { | ||
| 0..10 => {}, | ||
| 10..20 => {}, | ||
| 5..15 => {}, // FIXME: should be unreachable |
There was a problem hiding this comment.
Huh, I'm surprised our tests didn't cover this before. Good catch (and below).
There was a problem hiding this comment.
We don't have an issue for this already, do we?
There was a problem hiding this comment.
We don't, but I've got a PR ready to fix it
There was a problem hiding this comment.
I don't know how to solve the other FIXME so I guess we could raise an issue. But it's quite tiny, I'm not sure it's worth it
There was a problem hiding this comment.
It's worth opening an issue, just so we can keep track of it.
varkor
approved these changes
Nov 22, 2020
|
@bors r+ |
|
📌 Commit 3213efc has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hunted for tests that only exercised the match exhaustiveness algorithm and regrouped them. I also improved integer-range tests since I had found them lacking while hacking around.
The interest is mainly so that one can pass
--test-args patternsand catch most relevant tests.r? @varkor
@rustbot modify labels: +A-exhaustiveness-checking