Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #79357 unstable or-pat suggestions #79364

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Fixes #79357 unstable or-pat suggestions #79364

merged 1 commit into from
Dec 2, 2020

Conversation

nico-abram
Copy link
Contributor

@nico-abram nico-abram commented Nov 23, 2020 •
edited
Loading

Fixes #79357

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2020
@mark-i-m
Copy link
Member

cc @petrochenkov ?

@mark-i-m
Copy link
Member

I guess if #79278 lands in the same cycle as this PR, this one would get undone, unless we backport this PR to beta...

@nico-abram
Copy link
Contributor Author

I wouldn't expect a diagnostics change to be worth backporting (But I don't know what the policy is, if there is one)

Should this one be left open until near the end of the cycle, and only merged if or patterns don't get stabilized? (And closed if so)

@mark-i-m
Copy link
Member

@nico-abram I actually don't know. It looks like a pretty harmless PR to backport, and it improves UX, so maybe it could be backported. If it's not backported, I guess the plan you outlined makes sense.

@camelid camelid added A-diagnostics Area: Messages for errors, warnings, and lints A-patterns Relating to patterns and pattern matching labels Nov 23, 2020
@camelid
Copy link
Member

camelid commented Nov 23, 2020

I wouldn't expect this to be backported since this diagnostic has suggested or-patterns for several releases, and it's not even an incorrect suggestion – it is just invalid on stable.

@nico-abram nico-abram force-pushed the unstable-or-pat-suggestion branch 4 times, most recently from 502ae2b to 2b0bd99 Compare November 29, 2020 18:16
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Dec 2, 2020

📌 Commit de3a0bd has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 2, 2020
@bors
Copy link
Contributor

bors commented Dec 2, 2020

⌛ Testing commit de3a0bd with merge f4db9ff...

@bors
Copy link
Contributor

bors commented Dec 2, 2020

☀️ Test successful - checks-actions
Approved by: matthewjasper
Pushing f4db9ff to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 2, 2020
@bors bors merged commit f4db9ff into rust-lang:master Dec 2, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 2, 2020
@bors bors mentioned this pull request Dec 2, 2020
Merged
5 tasks
@mark-i-m
Copy link
Member

mark-i-m commented Dec 2, 2020

You beat me after all :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid left review comments

@matthewjasper matthewjasper matthewjasper left review comments

Assignees

@matthewjasper matthewjasper

Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-patterns Relating to patterns and pattern matching merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.

Compiler suggesting unstable or-pattern in for loop
7 participants
@nico-abram @rust-highfive @mark-i-m @camelid @matthewjasper @bors @rustbot