Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privatize some of libcore unicode_internals #79795

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Dec 7, 2020

My understanding is that these API are perma unstable, so it doesn't
make sense to pollute docs & IDE completion1 with them.

My understanding is that these API are perma unstable, so it doesn't
make sense to pollute docs & IDE completion[1] with them.

[1]: rust-lang/rust-analyzer#6738
@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 7, 2020
@cramertj
Copy link
Member

cramertj commented Dec 8, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Dec 8, 2020

📌 Commit 88da568 has been approved by cramertj

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 9, 2020
Rollup of 12 pull requests

Successful merges:

 - rust-lang#79732 (minor stylistic clippy cleanups)
 - rust-lang#79750 (Fix trimming of lint docs)
 - rust-lang#79777 (Remove `first_merge` from liveness debug logs)
 - rust-lang#79795 (Privatize some of libcore unicode_internals)
 - rust-lang#79803 (Update xsv to prevent random CI failures)
 - rust-lang#79810 (Account for gaps in def path table during decoding)
 - rust-lang#79818 (Fixes to Rust coverage)
 - rust-lang#79824 (Strip prefix instead of replacing it with empty string)
 - rust-lang#79826 (Simplify visit_{foreign,trait}_item)
 - rust-lang#79844 (Move RWUTable to a separate module)
 - rust-lang#79861 (Update LLVM submodule)
 - rust-lang#79862 (Remove tab-lock and replace it with ctrl+up/down arrows to switch between search result tabs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 26e4cf0 into rust-lang:master Dec 10, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants