Move EnumSet into libextra #8054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,6 +8,7 @@ | |||
| // option. This file may not be copied, modified, or distributed | |||
| // except according to those terms. | |||
|
|
|||
| #[allow(missing_doc)]; | |||
There was a problem hiding this comment.
libextra is normally held to a higher coding standard than librustc/libsyntax, especially in terms of documentation. That's why this is set to deny-by-default for these libraries. It'd be a shame to increase the amount of these, so would you mind adding documentation to the methods as well?
| pub trait CLike { | ||
| /// Converts an EnumSet to uint. |
There was a problem hiding this comment.
I don't think this actually has anything to do with EnumSet, also could you align these with the field declarations themselves?
|
Addressed all comments, and I also rebased this because of foreach syntax change. |
|
Sorry to be a bit picky, but as one final thing could you squash all the commits together? This seems like one nice change for a commit. Other than that though, r+ |
bors
added a commit
that referenced
this pull request
Aug 6, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 6, 2021
Upgrade map_flatten to complexity changelog: upgrade [`map_flatten`] to complexity Resolves rust-lang#7999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8004