Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support pattern as const parents in type_of #80551

Merged
merged 1 commit into from
Jan 1, 2021

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Dec 31, 2020

nice to know that there's still stuff about rust i didn't know about 😆

fixes #80531

r? @varkor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 31, 2020
@lcnr lcnr added the A-const-generics Area: const generics (parameters and arguments) label Dec 31, 2020
@varkor
Copy link
Member

varkor commented Dec 31, 2020

Maybe the delay in min_const_generics stabilisation was a good thing after all...

@lcnr lcnr force-pushed the const-arg-wildcard branch from 250461c to 2aef46b Compare December 31, 2020 13:11
@varkor
Copy link
Member

varkor commented Dec 31, 2020

Great, thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 31, 2020

📌 Commit 2aef46b has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2020
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Dec 31, 2020
support pattern as const parents in type_of

nice to know that there's still stuff about rust i didn't know about 😆

fixes rust-lang#80531

r? ``@varkor``
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 1, 2021
Rollup of 8 pull requests

Successful merges:

 - rust-lang#80323 (Update and improve `rustc_codegen_{llvm,ssa}` docs)
 - rust-lang#80368 (rustdoc: Render visibilities succinctly)
 - rust-lang#80514 (Fix broken ./x.py install)
 - rust-lang#80519 (Take type defaults into account in suggestions to reorder generic parameters)
 - rust-lang#80526 (Update LLVM)
 - rust-lang#80532 (remove unnecessary trailing semicolon from bootstrap)
 - rust-lang#80548 (FIx ICE on wf check for foreign fns)
 - rust-lang#80551 (support pattern as const parents in type_of)

Failed merges:

 - rust-lang#80547 (In which we start to parse const generics defaults)

r? `@ghost`
`@rustbot` modify labels: rollup
@camelid camelid added the A-patterns Relating to patterns and pattern matching label Jan 1, 2021
@bors bors merged commit 96c11f9 into rust-lang:master Jan 1, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-const-generics Area: const generics (parameters and arguments) A-patterns Relating to patterns and pattern matching S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE with const-generic enum pattern
6 participants