mk: Fix NO_REBUILD so stdtest can be tested without re-bootstrapping. Cl... #8110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bors
added a commit
that referenced
this pull request
Jul 30, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 17, 2021
…t, r=matthiaskrgr Update lintcheck output to use tables and add markdown support This PR updates changes lintcheck's output to use text tables and adds a markdown option to use Markdown links in the reports table. At first, I tried to keep the original output format, but the loading of old stats broke with the markdown option. The old format is therefore sadly incompatible with the new one. I can if requested make it in a way that the markdown output is only and optional additional output, but that would require more work for little benefit IMO. For now, lintcheck has two output types. Here are the examples (best viewed on desktop): <details> <summary>`cargo lintcheck --only anyhow`</summary> ```txt clippy 0.1.59 (460bef2 2021-12-08) ### Reports target/lintcheck/sources/anyhow-1.0.38/build.rs:1:null clippy::cargo_common_metadata "package `anyhow` is missing `package.keywords` metadata" target/lintcheck/sources/anyhow-1.0.38/src/error.rs:350:5 clippy::missing_panics_doc "docs for function which may panic missing `# Panics` section" target/lintcheck/sources/anyhow-1.0.38/src/lib.rs:1:null clippy::cargo_common_metadata "package `anyhow` is missing `package.keywords` metadata" ### Stats: | lint | count | | -------------------------------------------------- | ----- | | clippy::missing_panics_doc | 1 | | clippy::cargo_common_metadata | 2 | ### ICEs: ``` </details> <details> <summary>`cargo lintcheck --only anyhow --markdown` (The file links only work locally)</summary> clippy 0.1.59 (460bef2 2021-12-08) ### Reports | file | lint | message | | --- | --- | --- | | [`anyhow-1.0.38/build.rs:1:null`](../target/lintcheck/sources/anyhow-1.0.38/build.rs#L1) | `clippy::cargo_common_metadata` | "package `anyhow` is missing `package.keywords` metadata" | | [`anyhow-1.0.38/src/error.rs:350:5`](../target/lintcheck/sources/anyhow-1.0.38/src/error.rs#L350) | `clippy::missing_panics_doc` | "docs for function which may panic missing `# Panics` section" | | [`anyhow-1.0.38/src/lib.rs:1:null`](../target/lintcheck/sources/anyhow-1.0.38/src/lib.rs#L1) | `clippy::cargo_common_metadata` | "package `anyhow` is missing `package.keywords` metadata" | ### Stats: | lint | count | | -------------------------------------------------- | ----- | | clippy::missing_panics_doc | 1 | | clippy::cargo_common_metadata | 2 | ### ICEs: </details> The table margins are so large to keep the table inline for long file names and lint names --- changelog: none r? `@matthiaskrgr`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...oses #8101