Encode MIR metadata by iterating on DefId instead of traversing the HIR tree #81215

cjgillot · 2021-01-20T18:18:10Z

Split out of #80347.

This part only traverses mir_keys and encodes MIR according to the def kind.

tmiasko · 2021-01-20T18:35:02Z

compiler/rustc_metadata/src/rmeta/encoder.rs

+            (true, false)
+        }
+        // Closures and functions
+        DefKind::Generator | DefKind::Closure | DefKind::AssocFn | DefKind::Fn => {


Currently optimized MIR for generators is always required. I will have to revisit the tests if this implementation manages to pass them. EDIT: It doesn't.

rust-log-analyzer · 2021-01-20T18:37:05Z

The job x86_64-gnu-llvm-9 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:

---- [ui] ui/consts/const-int-arithmetic.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/const-int-arithmetic.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-int-arithmetic/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-int-arithmetic/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
error: any use of this value will cause an error
   |
   |
LL |                 const $label: $ty = $expr;
...
...
LL |         C41: 100i8.wrapping_div(10), 10;
   |              ^^^^^^^^^^^^^^^^^^^^^^ "calling extern function `core::num::<impl i8>::wrapping_div`" needs an rfc before being allowed inside constants
   |
   = note: `#[deny(const_err)]` on by default

error: any use of this value will cause an error
   |
   |
LL |                 const $label: $ty = $expr;
...
...
LL |         C42: (-128i8).wrapping_div(-1), -128;
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^ "calling extern function `core::num::<impl i8>::wrapping_div`" needs an rfc before being allowed inside constants

error: any use of this value will cause an error
   |
   |
LL |                 const $label: $ty = $expr;
...
...
LL |         C43: 100i8.wrapping_rem(10), 0;
   |              ^^^^^^^^^^^^^^^^^^^^^^ "calling extern function `core::num::<impl i8>::wrapping_rem`" needs an rfc before being allowed inside constants

error: any use of this value will cause an error
   |
   |
LL |                 const $label: $ty = $expr;
...
...
LL |         C44: (-128i8).wrapping_rem(-1), 0;
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^ "calling extern function `core::num::<impl i8>::wrapping_rem`" needs an rfc before being allowed inside constants
error: aborting due to 4 previous errors


------------------------------------------
------------------------------------------


---- [ui] ui/consts/const-size_of_val-align_of_val.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/const-size_of_val-align_of_val.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-size_of_val-align_of_val/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/const-size_of_val-align_of_val/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
error: any use of this value will cause an error
   |
   |
LL | const SIZE_OF_DANGLING: usize = unsafe { mem::size_of_val_raw(0x100 as *const i32) };
   |                                          |
   |                                          |
   |                                          "calling extern function `size_of_val_raw`" needs an rfc before being allowed inside constants
   |
   = note: `#[deny(const_err)]` on by default

error: any use of this value will cause an error
   |
   |
LL | const ALIGN_OF_DANGLING: usize = unsafe { mem::align_of_val_raw(0x100 as *const i16) };
   |                                           |
   |                                           |
   |                                           "calling extern function `align_of_val_raw`" needs an rfc before being allowed inside constants
error: aborting due to 2 previous errors


------------------------------------------
------------------------------------------


---- [ui] ui/consts/ptr_is_null.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit code: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/consts/ptr_is_null.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/ptr_is_null" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--crate-type=lib" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/consts/ptr_is_null/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
error: any use of this value will cause an error
   |
   |
LL | pub const _: () = assert!(!(FOO as *const usize).is_null());
   |                            |
   |                            |
   |                            "calling extern function `ptr::const_ptr::<impl *const T>::is_null`" needs an rfc before being allowed inside constants
   |
   = note: `#[deny(const_err)]` on by default

error: any use of this value will cause an error
   |
   |
LL | pub const _: () = assert!(!(42 as *const usize).is_null());
   |                            |
   |                            |
   |                            "calling extern function `ptr::const_ptr::<impl *const T>::is_null`" needs an rfc before being allowed inside constants

error: any use of this value will cause an error
   |
   |
LL | pub const _: () = assert!((0 as *const usize).is_null());
   |                           |
   |                           |
   |                           "calling extern function `ptr::const_ptr::<impl *const T>::is_null`" needs an rfc before being allowed inside constants

error: any use of this value will cause an error
   |
   |
LL | pub const _: () = assert!(std::ptr::null::<usize>().is_null());
   |                           |
   |                           |
   |                           "calling extern function `ptr::const_ptr::<impl *const T>::is_null`" needs an rfc before being allowed inside constants

error: any use of this value will cause an error
   |
   |
LL | pub const _: () = assert!(!("foo" as *const str).is_null());
   |                            |
   |                            |
   |                            "calling extern function `ptr::const_ptr::<impl *const T>::is_null`" needs an rfc before being allowed inside constants
error: aborting due to 5 previous errors


------------------------------------------
------------------------------------------


---- [ui] ui/generator/metadata-sufficient-for-layout.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit code: 101
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/generator/metadata-sufficient-for-layout.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zemit-future-incompat-report" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/generator/metadata-sufficient-for-layout" "-A" "unused" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/generator/metadata-sufficient-for-layout/auxiliary"
------------------------------------------

------------------------------------------
stderr:
stderr:
------------------------------------------
error: internal compiler error: compiler/rustc_metadata/src/rmeta/decoder.rs:1183:17: get_optimized_mir: missing MIR for `DefId(18:7 ~ metadata_sufficient_for_layout[8787]::g::{closure#0})`
thread 'rustc' panicked at 'Box<Any>', compiler/rustc_errors/src/lib.rs:958:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

note: the compiler unexpectedly panicked. this is a bug.
note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/issues/new?labels=C-bug%2C+I-ICE%2C+T-compiler&template=ice.md
note: rustc 1.51.0-nightly (0566609f2 2021-01-20) running on x86_64-unknown-linux-gnu


note: compiler flags: -Z threads=1 -Z ui-testing -Z deduplicate-diagnostics=no -Z emit-future-incompat-report -Z unstable-options -C prefer-dynamic -C rpath -C debuginfo=0
query stack during panic:
query stack during panic:
#0 [optimized_mir] optimizing MIR for `metadata_sufficient_for_layout::g::{closure#0}`
#1 [layout_raw] computing layout of `[generator@metadata_sufficient_for_layout::g::{closure#0} {()}]`
end of query stack


------------------------------------------

---

Some tests failed in compiletest suite=ui mode=ui host=x86_64-unknown-linux-gnu target=x86_64-unknown-linux-gnu


command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--suite" "ui" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-9/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python3" "--lldb-python" "/usr/bin/python3" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "9.0.0" "--llvm-components" "aarch64 aarch64asmparser aarch64codegen aarch64desc aarch64disassembler aarch64info aarch64utils aggressiveinstcombine all all-targets amdgpu amdgpuasmparser amdgpucodegen amdgpudesc amdgpudisassembler amdgpuinfo amdgpuutils analysis arm armasmparser armcodegen armdesc armdisassembler arminfo armutils asmparser asmprinter avr avrasmparser avrcodegen avrdesc avrdisassembler avrinfo binaryformat bitreader bitstreamreader bitwriter bpf bpfasmparser bpfcodegen bpfdesc bpfdisassembler bpfinfo codegen core coroutines coverage debuginfocodeview debuginfodwarf debuginfogsym debuginfomsf debuginfopdb demangle dlltooldriver engine executionengine fuzzmutate globalisel hexagon hexagonasmparser hexagoncodegen hexagondesc hexagondisassembler hexagoninfo instcombine instrumentation interpreter ipo irreader jitlink lanai lanaiasmparser lanaicodegen lanaidesc lanaidisassembler lanaiinfo libdriver lineeditor linker lto mc mca mcdisassembler mcjit mcparser mips mipsasmparser mipscodegen mipsdesc mipsdisassembler mipsinfo mirparser msp430 msp430asmparser msp430codegen msp430desc msp430disassembler msp430info native nativecodegen nvptx nvptxcodegen nvptxdesc nvptxinfo objcarcopts object objectyaml option orcjit passes perfjitevents powerpc powerpcasmparser powerpccodegen powerpcdesc powerpcdisassembler powerpcinfo profiledata remarks riscv riscvasmparser riscvcodegen riscvdesc riscvdisassembler riscvinfo riscvutils runtimedyld scalaropts selectiondag sparc sparcasmparser sparccodegen sparcdesc sparcdisassembler sparcinfo support symbolize systemz systemzasmparser systemzcodegen systemzdesc systemzdisassembler systemzinfo tablegen target textapi transformutils vectorize webassembly webassemblyasmparser webassemblycodegen webassemblydesc webassemblydisassembler webassemblyinfo windowsmanifest x86 x86asmparser x86codegen x86desc x86disassembler x86info x86utils xcore xcorecodegen xcoredesc xcoredisassembler xcoreinfo xray" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"


failed to run: /checkout/obj/build/bootstrap/debug/bootstrap --stage 2 test --exclude src/tools/tidy
Build completed unsuccessfully in 0:16:01

oli-obk · 2021-01-21T09:28:48Z

I don't have time to review before mid next week. @tmiasko do you want to take this one?

tmiasko

Nice work! I really like that now we have a single function responsible for deciding what to encode that can be reused between prefetcher & encoder. Additionally with MIR being encoded separately, we could easily include its size in statistics.

compiler/rustc_metadata/src/rmeta/encoder.rs

cjgillot · 2021-01-21T17:46:40Z

The change in diagnostics is probably due to the iteration order in mir_keys. Should I sort the mir_keys before encoding, or is the regression acceptable?

oli-obk · 2021-01-21T17:49:32Z

If the iteration order were stable, then the exact order would be irrelevant. But I'm guessing this order depends on a hash map. We would get spurious changes in ui tests failing all the time if we are dependent on a hashmap for diagnostics ordering.

src/test/incremental/hashes/let_expressions.rs

cjgillot · 2021-01-21T20:04:48Z

Last commit sorts the hash map to avoid the unstable iteration in diagnostics.

bors · 2021-01-24T10:15:20Z

☔ The latest upstream changes (presumably #80919) made this pull request unmergeable. Please resolve the merge conflicts.

cjgillot · 2021-01-24T11:46:45Z

Rebased with the test back-and-forth removed.

oli-obk · 2021-02-03T11:22:04Z

@bors try @rust-timer queue

rust-timer · 2021-02-03T11:22:05Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-02-03T11:22:19Z

⌛ Trying commit 5a60f0a with merge f7291779fd3275697027f6eefb933af7f154c92b...

compiler/rustc_metadata/src/rmeta/encoder.rs

bors · 2021-02-03T12:22:46Z

☀️ Try build successful - checks-actions
Build commit: f7291779fd3275697027f6eefb933af7f154c92b (f7291779fd3275697027f6eefb933af7f154c92b)

rust-timer · 2021-02-03T12:22:48Z

Queued f7291779fd3275697027f6eefb933af7f154c92b with parent b593389, future comparison URL.

rust-timer · 2021-02-03T15:00:01Z

Finished benchmarking try commit (f7291779fd3275697027f6eefb933af7f154c92b): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

cjgillot · 2021-02-03T21:13:05Z

Similar results.

oli-obk · 2021-02-04T12:38:41Z

Well... the CTFE stress test regression is completely gone. So that's good.

Now we're seeing a clap regression which has 90% more is_const_fn_raw invocations and 400% more mir_abstract_const invocations.

compiler/rustc_metadata/src/rmeta/encoder.rs

oli-obk · 2021-02-04T17:13:19Z

@bors try @rust-timer queue

rust-timer · 2021-02-04T17:13:20Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2021-02-04T17:13:44Z

⌛ Trying commit 09ac459 with merge d015793ce5cbbc0e7555778a818058a8d558a7ab...

bors · 2021-02-04T18:14:14Z

☀️ Try build successful - checks-actions
Build commit: d015793ce5cbbc0e7555778a818058a8d558a7ab (d015793ce5cbbc0e7555778a818058a8d558a7ab)

rust-timer · 2021-02-04T18:14:16Z

Queued d015793ce5cbbc0e7555778a818058a8d558a7ab with parent e708cbd, future comparison URL.

rust-timer · 2021-02-04T19:53:29Z

Finished benchmarking try commit (d015793ce5cbbc0e7555778a818058a8d558a7ab): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

cjgillot · 2021-02-04T20:27:12Z

The clap regression does not appear any more.

tmiasko · 2021-02-04T20:33:04Z

In wg-grammar some constructors are no longer queried in mir_for_ctfe & optimized_mir (don't know if this is a good thing or a bad thing):

2,90d1
< rust_grammar.parse-_C-Expr__0-{constructor#0}.-------.mir_map.0.mir
< rust_grammar.parse-_C-Expr__10__0-{constructor#0}.-------.mir_map.0.mir
< rust_grammar.parse-_C-Expr__10__1-{constructor#0}.-------.mir_map.0.mir
...
< rust_grammar.parse-_C-TOKEN_TREE-{constructor#0}.-------.mir_map.0.mir
17913,17997d17823
< rust_grammar.parse-ListHead-Nil-{constructor#0}.-------.mir_map.0.mir
< rust_grammar.parse-_P-_0-{constructor#0}.-------.mir_map.0.mir
...
< rust_grammar.parse-_P-_9-{constructor#0}.-------.mir_map.0.mir
18088d17913
< rust_grammar.parse-ParseError-NoParse-{constructor#0}.-------.mir_map.0.mir

tmiasko · 2021-02-04T21:10:33Z

It turns out we encoded MIR for fictive constructors previously.

oli-obk · 2021-02-05T09:54:23Z

Ok, I went over the leftover "regressions" (in the 0.x % range), and all of them seem to be because there's an additional call to mir_keys, which is actually below millisecond timing and thus only occurs on perf tests that themselves just take a few milliseconds.

@bors r+

bors · 2021-02-05T09:54:25Z

📌 Commit 09ac459 has been approved by oli-obk

bors · 2021-02-05T18:21:52Z

⌛ Testing commit 09ac459 with merge 23adf9f...

bors · 2021-02-05T21:12:01Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 23adf9f to master...

rust-highfive assigned oli-obk Jan 20, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 20, 2021

tmiasko reviewed Jan 20, 2021

View reviewed changes

cjgillot force-pushed the defkey-mir branch from 95d1c90 to 3ee9fed Compare January 20, 2021 20:18

tmiasko approved these changes Jan 21, 2021

View reviewed changes

compiler/rustc_metadata/src/rmeta/encoder.rs Outdated Show resolved Hide resolved

cjgillot commented Jan 21, 2021

View reviewed changes

src/test/incremental/hashes/let_expressions.rs Outdated Show resolved Hide resolved

cjgillot added 4 commits January 24, 2021 12:42

Introduce should_encode_mir.

f071b50

Refactor MIR metadata emission.

23d415a

Review comment.

d88420a

Sort mir_keys to ensure consistent diagnostic order.

5a60f0a

cjgillot force-pushed the defkey-mir branch from ec09b2b to 5a60f0a Compare January 24, 2021 11:46

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 3, 2021

oli-obk reviewed Feb 3, 2021

View reviewed changes

compiler/rustc_metadata/src/rmeta/encoder.rs Outdated Show resolved Hide resolved

oli-obk reviewed Feb 3, 2021

View reviewed changes

compiler/rustc_metadata/src/rmeta/encoder.rs Outdated Show resolved Hide resolved

Address review.

0658d8c

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 3, 2021

oli-obk reviewed Feb 4, 2021

View reviewed changes

compiler/rustc_metadata/src/rmeta/encoder.rs Show resolved Hide resolved

oli-obk reviewed Feb 4, 2021

View reviewed changes

compiler/rustc_metadata/src/rmeta/encoder.rs Outdated Show resolved Hide resolved

Encode less consts.

09ac459

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 4, 2021

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 4, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2021

bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 5, 2021

bors merged commit 23adf9f into rust-lang:master Feb 5, 2021

rustbot added this to the 1.51.0 milestone Feb 5, 2021

bors mentioned this pull request Feb 5, 2021

Only store a LocalDefId in some HIR nodes #81611

Merged

cjgillot deleted the defkey-mir branch February 5, 2021 23:15

cjgillot mentioned this pull request Feb 21, 2021

Generate metadata by iterating on DefId instead of traversing the HIR tree #80347

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Encode MIR metadata by iterating on DefId instead of traversing the HIR tree #81215

Encode MIR metadata by iterating on DefId instead of traversing the HIR tree #81215

cjgillot commented Jan 20, 2021

tmiasko Jan 20, 2021 •

edited

Loading

rust-log-analyzer commented Jan 20, 2021

oli-obk commented Jan 21, 2021

tmiasko left a comment

cjgillot commented Jan 21, 2021

oli-obk commented Jan 21, 2021

cjgillot commented Jan 21, 2021

bors commented Jan 24, 2021

cjgillot commented Jan 24, 2021

oli-obk commented Feb 3, 2021

rust-timer commented Feb 3, 2021

bors commented Feb 3, 2021

bors commented Feb 3, 2021

rust-timer commented Feb 3, 2021

rust-timer commented Feb 3, 2021

cjgillot commented Feb 3, 2021

oli-obk commented Feb 4, 2021

oli-obk commented Feb 4, 2021

rust-timer commented Feb 4, 2021

bors commented Feb 4, 2021

bors commented Feb 4, 2021

rust-timer commented Feb 4, 2021

rust-timer commented Feb 4, 2021

cjgillot commented Feb 4, 2021

tmiasko commented Feb 4, 2021

tmiasko commented Feb 4, 2021

oli-obk commented Feb 5, 2021

bors commented Feb 5, 2021

bors commented Feb 5, 2021

bors commented Feb 5, 2021

Encode MIR metadata by iterating on DefId instead of traversing the HIR tree #81215

Encode MIR metadata by iterating on DefId instead of traversing the HIR tree #81215

Conversation

cjgillot commented Jan 20, 2021

tmiasko Jan 20, 2021 • edited Loading

Choose a reason for hiding this comment

rust-log-analyzer commented Jan 20, 2021

oli-obk commented Jan 21, 2021

tmiasko left a comment

Choose a reason for hiding this comment

cjgillot commented Jan 21, 2021

oli-obk commented Jan 21, 2021

cjgillot commented Jan 21, 2021

bors commented Jan 24, 2021

cjgillot commented Jan 24, 2021

oli-obk commented Feb 3, 2021

rust-timer commented Feb 3, 2021

bors commented Feb 3, 2021

bors commented Feb 3, 2021

rust-timer commented Feb 3, 2021

rust-timer commented Feb 3, 2021

cjgillot commented Feb 3, 2021

oli-obk commented Feb 4, 2021

oli-obk commented Feb 4, 2021

rust-timer commented Feb 4, 2021

bors commented Feb 4, 2021

bors commented Feb 4, 2021

rust-timer commented Feb 4, 2021

rust-timer commented Feb 4, 2021

cjgillot commented Feb 4, 2021

tmiasko commented Feb 4, 2021

tmiasko commented Feb 4, 2021

oli-obk commented Feb 5, 2021

bors commented Feb 5, 2021

bors commented Feb 5, 2021

bors commented Feb 5, 2021

tmiasko Jan 20, 2021 •

edited

Loading