Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve suggestion for tuple struct pattern matching errors. #81235

Merged
merged 3 commits into from
Feb 23, 2021
Merged

Improve suggestion for tuple struct pattern matching errors. #81235

merged 3 commits into from
Feb 23, 2021

Commits on Jan 21, 2021

  1. Improve suggestion for tuple struct pattern matching errors.

    Currently, when a user uses a struct pattern to pattern match on
    a tuple struct, the errors we emit generally suggest adding fields
    using their field names, which are numbers. However, numbers are
    not valid identifiers, so the suggestions, which use the shorthand
    notation, are not valid syntax. This commit changes those errors
    to suggest using the actual tuple struct pattern syntax instead,
    which is a more actionable suggestion.
    reese committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    8a83c8f View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2021

  1. Configuration menu
    Copy the full SHA
    7879099 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2021

  1. Configuration menu
    Copy the full SHA
    d8540ae View commit details
    Browse the repository at this point in the history