combine: stop eagerly evaluating consts #81351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
lcnr
added
A-const-generics
|
Oh yea, this is much better than the @bors r+ |
|
📌 Commit 77a9e3e has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 77a9e3e with merge a66e013a0fccd15e427b25cc4122409e5fc1f5e9... |
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
not your fault, a lot of (all) PRs are failing right now |
|
@bors retry this should work again now |
bors
added
S-waiting-on-bors
This was referenced Jan 27, 2021
This was referenced Jan 27, 2021
henryboisdequin
added a commit
to henryboisdequin/rust
that referenced
this pull request
Jan 29, 2021
combine: stop eagerly evaluating consts `super_relate_consts` eagerly evaluates constants which doesn't seem too great. I now also finally understand why all of the unused substs test passed. The reason being that we just evaluated the constants in `super_relate_consts` 😆 While this change isn't strictly necessary as evaluating consts here doesn't hurt, it still feels a lot cleaner to do it this way r? `@oli-obk` `@nikomatsakis`
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Jan 30, 2021
combine: stop eagerly evaluating consts `super_relate_consts` eagerly evaluates constants which doesn't seem too great. I now also finally understand why all of the unused substs test passed. The reason being that we just evaluated the constants in `super_relate_consts` 😆 While this change isn't strictly necessary as evaluating consts here doesn't hurt, it still feels a lot cleaner to do it this way r? `@oli-obk` `@nikomatsakis`
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
|
⌛ Testing commit 464148861190c9ca672b791c8f844b2ae90fe039 with merge b3f2d67077ff5351688e467fe7a90a8c0e5ea72f... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
camelid
added
the
S-waiting-on-author
lcnr
force-pushed
the
big-money-big-prices
branch
from
4641488 to
e461ddd
Compare
|
@bors r=oli-obk |
|
📌 Commit e461ddd has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit e461ddd with merge ec6a92f2161b0ac80d6333dee4d29a115097a062... |
|
@bors retry (included in rollup) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 27, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#81351 (combine: stop eagerly evaluating consts) - rust-lang#82525 (make unaligned_references future-incompat lint warn-by-default) - rust-lang#82626 (update array missing `IntoIterator` msg) - rust-lang#82917 (Add function core::iter::zip) - rust-lang#82993 (rustdoc: Use diagnostics for error when including sources) - rust-lang#83522 (Improve fs error open_from unix) - rust-lang#83548 (Always preserve `None`-delimited groups in a captured `TokenStream`) - rust-lang#83555 (Add #[inline] to io::Error methods) Failed merges: - rust-lang#83130 (escape_ascii take 2) r? `@ghost` `@rustbot` modify labels: rollup
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
super_relate_constseagerly evaluates constants which doesn't seem too great.I now also finally understand why all of the unused substs test passed. The reason being
that we just evaluated the constants in
super_relate_consts😆While this change isn't strictly necessary as evaluating consts here doesn't hurt, it still feels a lot cleaner to do it this way
r? @oli-obk @nikomatsakis