Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the monorepo's lockfile when building cargo for PGO profiling #81380

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

pietroalbini
Copy link
Member

Fixes #81378. The description of the problem and the reasoning for the fix is in the source code comments.

r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 25, 2021
@Mark-Simulacrum
Copy link
Member

@bors rollup=never r+

@bors
Copy link
Contributor

bors commented Jan 25, 2021

📌 Commit b2e6f33 has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jan 25, 2021

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2021
@pietroalbini
Copy link
Member Author

@bors p=1000

@bors
Copy link
Contributor

bors commented Jan 25, 2021

⌛ Testing commit b2e6f33 with merge 84864bf...

@bors
Copy link
Contributor

bors commented Jan 25, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 84864bf to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 25, 2021
@bors bors merged commit 84864bf into rust-lang:master Jan 25, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 25, 2021
@pietroalbini pietroalbini deleted the cargo-pgo-lockfile branch January 25, 2021 15:32
@camsteffen
Copy link
Contributor

This didn't work? Other PR's are still failing 😢.

@pietroalbini
Copy link
Member Author

@camsteffen do you have a link to a failed build?

@camsteffen
Copy link
Contributor

Sorry I take it back, it was a different error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiling cargo fails during PGO profiling
6 participants