-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visit only statements in always live locals #81440
Conversation
No functional changes intended.
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors rollup=never |
@bors try @rust-timer queue |
Awaiting bors try build completion. |
⌛ Trying commit 5686593 with merge 8baba0d590839b6c9f17ffc12b15300e5f1ef43a... |
☀️ Try build successful - checks-actions |
Queued 8baba0d590839b6c9f17ffc12b15300e5f1ef43a with parent 613ef74, future comparison URL. @rustbot label: +S-waiting-on-perf |
Finished benchmarking try commit (8baba0d590839b6c9f17ffc12b15300e5f1ef43a): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
@bors r+ |
📌 Commit 5686593 has been approved by |
☀️ Test successful - checks-actions |
This PR was benchmarked once before merging and then again after, the results are quite telling in terms of measurement errors associated with some benchmarks (especially that PR itself is rather insignificant):
It was my general impression that keccak instruction count results shifts between two relatively stable positions, in otherwise unpredictable manner. FYI @rust-lang/wg-compiler-performance |
No functional changes intended.