Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visit only statements in always live locals #81440

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jan 27, 2021

No functional changes intended.

No functional changes intended.
@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2021
@tmiasko
Copy link
Contributor Author

tmiasko commented Jan 27, 2021

@bors rollup=never

@tmiasko
Copy link
Contributor Author

tmiasko commented Jan 27, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Contributor

bors commented Jan 27, 2021

⌛ Trying commit 5686593 with merge 8baba0d590839b6c9f17ffc12b15300e5f1ef43a...

@bors
Copy link
Contributor

bors commented Jan 27, 2021

☀️ Try build successful - checks-actions
Build commit: 8baba0d590839b6c9f17ffc12b15300e5f1ef43a (8baba0d590839b6c9f17ffc12b15300e5f1ef43a)

@rust-timer
Copy link
Collaborator

Queued 8baba0d590839b6c9f17ffc12b15300e5f1ef43a with parent 613ef74, future comparison URL.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 27, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (8baba0d590839b6c9f17ffc12b15300e5f1ef43a): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 28, 2021
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 28, 2021

📌 Commit 5686593 has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2021
@bors
Copy link
Contributor

bors commented Jan 29, 2021

⌛ Testing commit 5686593 with merge 099f27b...

@bors
Copy link
Contributor

bors commented Jan 29, 2021

☀️ Test successful - checks-actions
Approved by: matthewjasper
Pushing 099f27b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 29, 2021
@bors bors merged commit 099f27b into rust-lang:master Jan 29, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 29, 2021
@tmiasko tmiasko deleted the always-live-locals branch January 29, 2021 11:34
@tmiasko
Copy link
Contributor Author

tmiasko commented Jan 29, 2021

This PR was benchmarked once before merging and then again after, the results are quite telling in terms of measurement errors associated with some benchmarks (especially that PR itself is rather insignificant):

It was my general impression that keccak instruction count results shifts between two relatively stable positions, in otherwise unpredictable manner. FYI @rust-lang/wg-compiler-performance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants