rustdoc: Move display_fn struct inside display_fn
#81497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camelid
added
C-cleanup
rust-highfive
added
the
S-waiting-on-review
|
Guillaume, I've been assigning you on a lot of PRs recently since Joshua is on |
camelid
commented
Jan 29, 2021
bugadani
reviewed
Jan 29, 2021
bugadani
reviewed
Jan 29, 2021
It's fine, I have been assigning you on a few of mine as (if you could look at #80883 please 😛 ) and @bugadani is helping me reviewing (thank you too!). |
Minor things only, though and I don't have much time for that either :/ |
|
It's completely fine. A bit of time from a few people is still very helpful! :) |
|
Since there seems to be consensus that it's better with the |
This makes it clear that it's an implementation detail of `display_fn` and shouldn't be used elsewhere, and it enforces in the compiler that no one else can use it.
camelid
force-pushed
the
rustdoc-display_fn-remove-cell
branch
from
e6680f2 to
c34faad
Compare
camelid
changed the title
Cell and Option in display_fndisplay_fn struct inside display_fn
|
@bors r+ rollup |
|
📌 Commit c34faad has been approved by |
bors
added
S-waiting-on-bors
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Feb 4, 2021
…ell, r=jyn514 rustdoc: Move `display_fn` struct inside `display_fn` This makes it clear that it's an implementation detail of `display_fn` and shouldn't be used elsewhere, and it enforces in the compiler that no one else can use it. r? `@GuillaumeGomez`
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Feb 4, 2021
…ell, r=jyn514 rustdoc: Move `display_fn` struct inside `display_fn` This makes it clear that it's an implementation detail of `display_fn` and shouldn't be used elsewhere, and it enforces in the compiler that no one else can use it. r? ``@GuillaumeGomez``
m-ou-se
added a commit
to m-ou-se/rust
that referenced
this pull request
Feb 5, 2021
…ell, r=jyn514 rustdoc: Move `display_fn` struct inside `display_fn` This makes it clear that it's an implementation detail of `display_fn` and shouldn't be used elsewhere, and it enforces in the compiler that no one else can use it. r? ```@GuillaumeGomez```
This was referenced Feb 5, 2021
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 5, 2021
Rollup of 15 pull requests Successful merges: - rust-lang#79554 (Generic associated types in trait paths) - rust-lang#80726 (relax adt unsizing requirements) - rust-lang#81307 (Handle `Span`s for byte and raw strings and add more detail ) - rust-lang#81318 (rustdoc-json: Fix has_body) - rust-lang#81456 (Make remote-test-server easier to use with new targets) - rust-lang#81497 (rustdoc: Move `display_fn` struct inside `display_fn`) - rust-lang#81500 (Remove struct_type from union output) - rust-lang#81542 (Expose correct symlink API on WASI) - rust-lang#81676 (Add more information to the error code for 'crate not found') - rust-lang#81682 (Add additional bitset benchmarks) - rust-lang#81730 (Make `Allocator` object-safe) - rust-lang#81763 (Cleanup rustdoc pass descriptions a bit) - rust-lang#81767 (Update LayoutError/LayoutErr stability attributes) - rust-lang#81771 (Indicate change in RSS from start to end of pass in time-passes output) - rust-lang#81781 (Fix `install-awscli.sh` error in CI) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it clear that it's an implementation detail of
display_fnand shouldn't be used elsewhere, and it enforces in the compiler that no
one else can use it.
r? @GuillaumeGomez