Rustdoc UI fixes #81592
Merged
Rustdoc UI fixes #81592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
added
T-rustdoc
|
Some changes occurred in HTML/CSS/JS. |
rust-highfive
added
the
S-waiting-on-review
pickfire
reviewed
Jan 31, 2021
| @@ -1578,7 +1578,7 @@ h4 > .notable-traits { | |||
| } | |||
| } | |||
|
|
|||
| @media (max-width: 416px) { | |||
| @media (max-width: 464px) { | |||
There was a problem hiding this comment.
Feels like a hacky solution to me, what if the width is slightly smaller or larger? Ideally we would want something to do with dynamic width like calc but that would also make stuff more complicated.
There was a problem hiding this comment.
It actually depends on the min width of the search input mostly. ;)
There was a problem hiding this comment.
Other than that, on mobile, once you click on the menu, the body jumps off, that behavior looks weird.
There was a problem hiding this comment.
Do you mean the body jumping down when you click the hamburger? That appears to be a nightly regression, it doesn't happen on the stable docs.
|
The nightly title text looks off. |
pickfire
approved these changes
Jan 31, 2021
|
@pickfire: I think this PR is already "diverse" enough. Can you open an issue for the text problem please? EDIT: The problem is even worse than what I had in mind:
|
|
@bors r+ |
|
📌 Commit be9b112 has been approved by |
bors
added
S-waiting-on-bors
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Feb 1, 2021
…Nemo157 Rustdoc UI fixes The first commit fixes this bug (I couldn't figure out why we were setting the width manually and it works as expected without so...):  The second commit fixes a small bug. On tablets or computer with very little width, the search section goes "over" the search input, making it impossible to click on the search input:  The third and last commit fixes two bugs that you can see in this screenshot:  The wheel is going over the search input and the search tab is going under the search results text. The bug was fixed by simply switching to "mobile mode" at a bigger width:  cc `@pickfire` r? `@Nemo157`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 1, 2021
…as-schievink Rollup of 12 pull requests Successful merges: - rust-lang#78641 (Let io::copy reuse BufWriter buffers) - rust-lang#79291 (Add error message for private fn) - rust-lang#81364 (Improve `rustc_mir_build::matches` docs) - rust-lang#81387 (Move some tests to more reasonable directories - 3) - rust-lang#81463 (Rename NLL* to Nll* accordingly to C-CASE) - rust-lang#81504 (Suggest accessing field when appropriate) - rust-lang#81529 (Fix invalid camel case suggestion involving unicode idents) - rust-lang#81536 (Indicate both start and end of pass RSS in time-passes output) - rust-lang#81592 (Rustdoc UI fixes) - rust-lang#81594 (Avoid building LLVM just for llvm-dwp) - rust-lang#81598 (Fix calling convention for CRT startup) - rust-lang#81618 (Sync rustc_codegen_cranelift) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit fixes this bug (I couldn't figure out why we were setting the width manually and it works as expected without so...):
The second commit fixes a small bug. On tablets or computer with very little width, the search section goes "over" the search input, making it impossible to click on the search input:
The third and last commit fixes two bugs that you can see in this screenshot:
The wheel is going over the search input and the search tab is going under the search results text. The bug was fixed by simply switching to "mobile mode" at a bigger width:
cc @pickfire
r? @Nemo157