Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the dummy cache in DocContext; delete RenderInfo #82018

Merged
merged 3 commits into from
Mar 2, 2021
Merged

Remove the dummy cache in DocContext; delete RenderInfo #82018

merged 3 commits into from
Mar 2, 2021

Commits on Mar 1, 2021

  1. Remove the dummy cache in DocContext 

    The same information is available everywhere; the only reason the dummy
cache was needed is because it waas previously stored in three different
places. This consolidates the info a bit so the cache in `DocContext` is
used throughout. As a bonus, it means `renderinfo` is used much much
less.

- Return a `Cache` from `run_global_ctxt`, not `RenderInfo`
- Remove the unused `render_info` from `run_renderer`
- Remove RefCell around `inlined`
- Add intra-doc links
    @jyn514
    jyn514 committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    4d7a648 View commit details
    Browse the repository at this point in the history

  2. Remove unused RenderInfo struct

    @jyn514
    jyn514 committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    163b01a View commit details
    Browse the repository at this point in the history

  3. Remove krate.version; fix crate_version in JSON 

    Previously, `JsonRenderer::after_krate` called `krate.version.clone()`.
The problem was it did that after the version was already moved into the
cache, so it would always be None. The fix was to get the version from
the cache instead.
    @jyn514
    jyn514 committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    be069a6 View commit details
    Browse the repository at this point in the history