Use debug log level for developer oriented logs #82029
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
cc @Aaron1011, @Nadrieril, @oli-obk in the case you would like to keep the existing log level for some of those. |
|
Looks good to me! |
The information logged here is of limited general interest, while at the same times makes it impractical to simply enable logging and share the resulting logs due to the amount of the output produced. Reduce log level from info to debug for developer oriented information. For example, when building cargo, this reduces the amount of logs generated by `RUSTC_LOG=info cargo build` from 265 MB to 79 MB. Continuation of changes from 81350.
|
@bors r+ rollup |
|
📌 Commit 06381ea660af2fe18dd62317f43df0c3b4860e61 has been approved by |
bors
added
S-waiting-on-bors
|
cc @RalfJung the logging levels for the miri-engine got lowered from |
|
Which ones? I think the logging that says which MIR statement will be executed should remain at |
| @@ -77,7 +77,7 @@ impl<'mir, 'tcx: 'mir, M: Machine<'mir, 'tcx>> InterpCx<'mir, 'tcx, M> { | |||
| /// Runs the interpretation logic for the given `mir::Statement` at the current frame and | |||
| /// statement counter. This also moves the statement counter forward. | |||
| crate fn statement(&mut self, stmt: &mir::Statement<'tcx>) -> InterpResult<'tcx> { | |||
| info!("{:?}", stmt); | |||
There was a problem hiding this comment.
I would really like to keep this (and the other Miri changes here) at info! so that this level of logging is available for regular rustc builds.
Well really, I don't care what level it is at, as long as I can make rustc emit this without having to build a rustc with debug assertions enabled. AFAIK debug! and trace! are compiled out entirely for release builds, so info! is the lowest it can be at for that.
|
@bors r- |
bors
added
S-waiting-on-author
|
we could lower the logging level cutoff for release mode to |
|
That would resolve my concern. Or maybe there's a way to sidestep the |
|
Reverted changes to interpreter. Please take another look. |
|
I have no stake in the remaining changes and thus no objection. However, I do concede that emitting a log line per CTFE instruction can be quite verbose. I was not aware that |
|
@bors r+ |
|
📌 Commit 361dcd5 has been approved by |
bors
added
S-waiting-on-bors
Rollup of 11 pull requests Successful merges: - rust-lang#80523 (#[doc(inline)] sym_generated) - rust-lang#80920 (Visit more targets when validating attributes) - rust-lang#81720 (Updated smallvec version due to RUSTSEC-2021-0003) - rust-lang#81891 ([rustdoc-json] Make `header` a vec of modifiers, and FunctionPointer consistent) - rust-lang#81912 (Implement the precise analysis pass for lint `disjoint_capture_drop_reorder`) - rust-lang#81914 (Fixing bad suggestion for `_` in `const` type when a function rust-lang#81885) - rust-lang#81919 (BTreeMap: fix internal comments) - rust-lang#81927 (Add a regression test for rust-lang#32498) - rust-lang#81965 (Fix MIR pretty printer for non-local DefIds) - rust-lang#82029 (Use debug log level for developer oriented logs) - rust-lang#82056 (fix ice (rust-lang#82032)) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
The information logged here is of limited general interest, while at the
same times makes it impractical to simply enable logging and share the
resulting logs due to the amount of the output produced.
Reduce log level from info to debug for developer oriented information.
For example, when building cargo, this reduces the amount of logs
generated by
RUSTC_LOG=info cargo buildfrom 265 MB to 79 MB.Continuation of changes from 81350.