Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an old FIXME comment and inline attribute #82634

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

osa1
Copy link
Contributor

@osa1 osa1 commented Feb 28, 2021

Apparently #35870 caused a problem in this code (which originally
returned an impl trait) and #[inline] was added as a workaround, in
ade79d7.

The issue is now fixed and the comment and #[inline] can now be
removed.

Apparently rust-lang#35870 caused a problem in this code (which originally
returned an impl trait) and `#[inline]` was added as a workaround, in
ade79d7.

The issue is now fixed and the comment and `#[inline]` can now be
removed.
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 28, 2021
@Aaron1011
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 28, 2021
@bors
Copy link
Contributor

bors commented Feb 28, 2021

⌛ Trying commit c4b90df with merge 21756682dd6c928ccfaf623929beefa852865f13...

@bors
Copy link
Contributor

bors commented Feb 28, 2021

☀️ Try build successful - checks-actions
Build commit: 21756682dd6c928ccfaf623929beefa852865f13 (21756682dd6c928ccfaf623929beefa852865f13)

@rust-timer
Copy link
Collaborator

Queued 21756682dd6c928ccfaf623929beefa852865f13 with parent 1b1d85f, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (21756682dd6c928ccfaf623929beefa852865f13): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 28, 2021
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 1, 2021

📌 Commit c4b90df has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2021
@bors
Copy link
Contributor

bors commented Mar 2, 2021

⌛ Testing commit c4b90df with merge edeee91...

@bors
Copy link
Contributor

bors commented Mar 2, 2021

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing edeee91 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 2, 2021
@bors bors merged commit edeee91 into rust-lang:master Mar 2, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 2, 2021
@osa1 osa1 deleted the osa1/remove_old_fixme branch March 2, 2021 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants