-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove an old FIXME comment and inline attribute #82634
Conversation
Apparently rust-lang#35870 caused a problem in this code (which originally returned an impl trait) and `#[inline]` was added as a workaround, in ade79d7. The issue is now fixed and the comment and `#[inline]` can now be removed.
(rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit c4b90df with merge 21756682dd6c928ccfaf623929beefa852865f13... |
☀️ Try build successful - checks-actions |
Queued 21756682dd6c928ccfaf623929beefa852865f13 with parent 1b1d85f, future comparison URL. |
Finished benchmarking try commit (21756682dd6c928ccfaf623929beefa852865f13): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
@bors r+ |
📌 Commit c4b90df has been approved by |
☀️ Test successful - checks-actions |
Apparently #35870 caused a problem in this code (which originally
returned an impl trait) and
#[inline]
was added as a workaround, inade79d7.
The issue is now fixed and the comment and
#[inline]
can now beremoved.