Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jemalloc usage on OSX #82642

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Fix jemalloc usage on OSX #82642

merged 2 commits into from
Mar 8, 2021

Conversation

sfackler
Copy link
Member

Closes #82423

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 28, 2021
@sfackler
Copy link
Member Author

cc @ehuss

@pnkfelix
Copy link
Member

pnkfelix commented Mar 1, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Mar 1, 2021

📌 Commit 6e52b23 has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 2, 2021
@Dylan-DPC
Rollup merge of rust-lang#82642 - sfackler:jemalloc-zone, r=pnkfelix
a90d462 
Fix jemalloc usage on OSX

Closes rust-lang#82423
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 5, 2021
@JohnTitor
Rollup merge of rust-lang#82642 - sfackler:jemalloc-zone, r=pnkfelix
a482925 
Fix jemalloc usage on OSX

Closes rust-lang#82423
@JohnTitor JohnTitor mentioned this pull request Mar 5, 2021
Closed
@JohnTitor
Copy link
Member

Failed in rollup: #82790 (comment)

@bors r- rollup=iffy

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 5, 2021
sfackler
sfackler commented Mar 5, 2021
View reviewed changes
compiler/rustc/src/main.rs Outdated Show resolved Hide resolved
@sfackler
Copy link
Member Author

sfackler commented Mar 5, 2021

Whoops

@bors r=pnkfelix

@bors
Copy link
Contributor

bors commented Mar 5, 2021

📌 Commit 1b4860a has been approved by pnkfelix

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 5, 2021
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 8, 2021
@Dylan-DPC
Rollup merge of rust-lang#82642 - sfackler:jemalloc-zone, r=pnkfelix
b6d1f77 
Fix jemalloc usage on OSX

Closes rust-lang#82423
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 8, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 8, 2021
@Dylan-DPC
Rollup merge of rust-lang#82642 - sfackler:jemalloc-zone, r=pnkfelix
a5bb582 
Fix jemalloc usage on OSX

Closes rust-lang#82423
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 8, 2021
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 8, 2021
@Dylan-DPC
Rollup merge of rust-lang#82642 - sfackler:jemalloc-zone, r=pnkfelix
d153d8c 
Fix jemalloc usage on OSX

Closes rust-lang#82423
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 8, 2021
@Dylan-DPC
Rollup merge of rust-lang#82642 - sfackler:jemalloc-zone, r=pnkfelix
9564b97 
Fix jemalloc usage on OSX

Closes rust-lang#82423
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 8, 2021
Closed
This was referenced Mar 8, 2021
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 8, 2021
@bors
Auto merge of rust-lang#82896 - Dylan-DPC:rollup-9setmme, r=Dylan-DPC
8f349be 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#82047 (bypass auto_da_alloc for metadata files)
 - rust-lang#82415 (expand: Refactor module loading)
 - rust-lang#82557 (Add natvis for Result, NonNull, CString, CStr, and Cow)
 - rust-lang#82613 (Remove Item::kind, use tagged enum. Rename variants to match)
 - rust-lang#82642 (Fix jemalloc usage on OSX)
 - rust-lang#82682 (Implement built-in attribute macro `#[cfg_eval]` + some refactoring)
 - rust-lang#82684 (Disable destination propagation on all mir-opt-levels)
 - rust-lang#82755 (Refactor confirm_builtin_call, remove partial if)
 - rust-lang#82857 (Edit ructc_ast_lowering docs)
 - rust-lang#82862 (Generalize Write impl for Vec<u8> to Vec<u8, A>)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7b78d86 into rust-lang:master Mar 8, 2021
@ehuss
Copy link
Contributor

ehuss commented Mar 9, 2021

I did some basic benchmarks, and it looks like this had a fairly significant improvement! Thanks @sfackler!

cargo:

Benchmark #1: PATH=/Users/eric/.rustup/toolchains/nightly-x86_64-apple-darwin/bin:$PATH cargo build
  Time (mean ± σ):     66.658 s ±  0.394 s    [User: 299.565 s, System: 27.624 s]
  Range (min … max):   66.380 s … 66.937 s    2 runs

Benchmark #2: PATH=/Users/eric/.rustup/toolchains/nightly-2021-03-08-x86_64-apple-darwin/bin:$PATH cargo build
  Time (mean ± σ):     75.251 s ±  0.283 s    [User: 337.470 s, System: 28.521 s]
  Range (min … max):   75.051 s … 75.451 s    2 runs

Summary
  'PATH=/Users/eric/.rustup/toolchains/nightly-x86_64-apple-darwin/bin:$PATH cargo build' ran
    1.13 ± 0.01 times faster than 'PATH=/Users/eric/.rustup/toolchains/nightly-2021-03-08-x86_64-apple-darwin/bin:$PATH cargo build'

toml-rs:

Benchmark #1: PATH=/Users/eric/.rustup/toolchains/nightly-x86_64-apple-darwin/bin:$PATH cargo build
  Time (mean ± σ):      5.968 s ±  0.010 s    [User: 7.561 s, System: 0.493 s]
  Range (min … max):    5.961 s …  5.975 s    2 runs

Benchmark #2: PATH=/Users/eric/.rustup/toolchains/nightly-2021-03-08-x86_64-apple-darwin/bin:$PATH cargo build
  Time (mean ± σ):      6.777 s ±  0.049 s    [User: 8.598 s, System: 0.509 s]
  Range (min … max):    6.743 s …  6.812 s    2 runs

Summary
  'PATH=/Users/eric/.rustup/toolchains/nightly-x86_64-apple-darwin/bin:$PATH cargo build' ran
    1.14 ± 0.01 times faster than 'PATH=/Users/eric/.rustup/toolchains/nightly-2021-03-08-x86_64-apple-darwin/bin:$PATH cargo build'

ripgrep:

Benchmark #1: PATH=/Users/eric/.rustup/toolchains/nightly-x86_64-apple-darwin/bin:$PATH cargo build
  Time (mean ± σ):     19.493 s ±  0.057 s    [User: 126.485 s, System: 8.628 s]
  Range (min … max):   19.452 s … 19.533 s    2 runs

Benchmark #2: PATH=/Users/eric/.rustup/toolchains/nightly-2021-03-08-x86_64-apple-darwin/bin:$PATH cargo build
  Time (mean ± σ):     22.563 s ±  0.665 s    [User: 147.224 s, System: 9.124 s]
  Range (min … max):   22.093 s … 23.033 s    2 runs

Summary
  'PATH=/Users/eric/.rustup/toolchains/nightly-x86_64-apple-darwin/bin:$PATH cargo build' ran
    1.16 ± 0.03 times faster than 'PATH=/Users/eric/.rustup/toolchains/nightly-2021-03-08-x86_64-apple-darwin/bin:$PATH cargo build'

@cuviper cuviper added this to the 1.52.0 milestone Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.

jemalloc does not seem to be working for rustc on macos
8 participants
@sfackler @rust-highfive @pnkfelix @bors @JohnTitor @ehuss @cuviper @estebank