Move some tests to more suitable subdirs

[JohnTitor]

The results from classifui

(The full results can be found here: https://gist.github.com/JohnTitor/c9e00840990b5e4a8fc562ec3571e427)

• lint-expr-stmt-attrs-for-early-lints.rs ^unknown: lint (1.566), feature-gates (-0.632), numbers-arithmetic (-0.955)
• try-block.rs ^unknown: binding (1.385), try-block (-0.097), lint (-0.932)
• backtrace-debuginfo.rs ^unknown: macros (1.365), cfg (-0.279), drop (-0.291)
• issues/issue-3521.rs ^issue: consts (1.298), enum (-0.872), in-band-lifetimes (-0.978)
• impl-bounds-checking.rs ^unknown: traits (1.243), for (-0.999), shadowed (-0.999)
• issues/issue-17718.rs ^issue: binding (1.236), consts (0.315), extern (-0.779)
• issue-6157.rs ^issue: regions (1.213), unboxed-closures (-0.285), traits (-0.510)
• issues/issue-44373.rs ^issue: consts (1.187), nll (0.427), borrowck (-0.704)
• nullable-pointer-ffi-compat.rs ^unknown: regions (1.184), consts (0.650), traits (-0.571)
• issues/issue-52992.rs ^issue: nll (1.132), associated-types (-0.628), parser (-0.893)
• issues/issue-2330.rs ^issue: traits (1.116), directory_ownership (-0.691), compare-method (-0.981)
• issue-74047.rs ^issue: async-await (1.109), impl-trait (-0.629), resolve (-0.781)
• issues/issue-33140.rs ^issue: traits (1.063), coherence (-0.832), codemap_tests (-0.944)
• issues/issue-28576.rs ^issue: traits (1.062), associated-types (-0.333), impl-trait (-0.697)
• issues/issue-7222.rs ^issue: binding (1.062), consts (-0.226), numbers-arithmetic (-0.294)
• tup.rs ^unknown: structs-enums (1.061), threads-sendsync (-0.550), moves (-0.790)
• issues/issue-15261.rs ^issue: consts (1.052), where-clauses (-0.833), macros (-0.862)
• issues/issue-76179.rs ^issue: associated-types (1.048), process (-0.887), rfc-2457 (-0.984)
• issues/issue-42344.rs ^issue: borrowck (1.043), macros (-0.481), specialization (-0.966)
• issues/issue-18661.rs ^issue: unboxed-closures (1.038), mir (-0.648), higher-rank-trait-bounds (-0.688)
• issues/issue-2633.rs ^issue: structs-enums (1.020), functions-closures (-0.722), lint (-0.967)

Some notes:

• If there are related tests (e.g. it's for the same issue), they are moved along with it.
• Moved try-block.rs to the try-block dir.
• Moved tup.rs to the tuple dir.
• Moved some tests that classified as consts to the statics dir, as it seems they have statics actually.
• Skipped backtrace-debuginfo.rs because I think classifui overrates their helper macros.

cc #73494
r? @petrochenkov

[petrochenkov]

Some tests at the top of the list are actually misclassifications, but have unproportionally high scores because they were left alone by the previous PRs moving all other high-score issues.

Misclassified:

• issue-17718.rs - binding subdirectory is known to be filled with random garbage (Tracking issue for moving ui tests to subdirectories #73494 (comment)), everything that is classified into it is likely a misclassification
• issue-7222.rs - binding subdirectory is known to be filled with random garbage (Tracking issue for moving ui tests to subdirectories #73494 (comment)), everything that is classified into it is likely a misclassification
• nullable-pointer-ffi-compat.rs - not sure what is this about (transmute? abi?), but certainly not regions
• issue-2633.rs - looks like this was originally about borrow checking, but the issue is extremely old (2012), perhaps its time to remove the test, as it doesn't seem to serve any useful goal now
• issue-2330.rs - move to resolve, this is simply an "expected resolution x, found resolution y" error

[JohnTitor]

Thanks! Addressed the review via f81b3be.

• Moved issue-17718.rs to consts
• Moved issue-7222.rs to parser
• Moved nullable-pointer-ffi-compat.rs to abi
• Removed issue-2633.rs and issue-2633-2.rs
• Moved issue-2330.rs to resolve

Once you check it, I'm going to squash :)

[petrochenkov]

r=me after squashing.

[JohnTitor]

@bors r=petrochenkov

[bors]

📌 Commit eb9abea has been approved by petrochenkov