Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit rustc_expand::base docs #82819

Closed
wants to merge 1 commit into from
Closed

Edit rustc_expand::base docs #82819

wants to merge 1 commit into from

Conversation

pierwill
Copy link
Member

@pierwill pierwill commented Mar 5, 2021

Fix missing punctuation and formatting. Split a few sentences for readability. Make a few wording changes.

@rust-highfive
Copy link
Collaborator

r? @varkor

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2021
@pierwill
Edit rustc_expand::base docs
2dcee9e 
Fix missing punctuation and formatting. Split a few sentences for
readability. Make a few wording changes.
@varkor
Copy link
Member

varkor commented Mar 7, 2021

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 7, 2021

📌 Commit 2dcee9e has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 7, 2021
@petrochenkov
Copy link
Contributor

@pierwill
With the number of such PRs growing it is getting somewhat closer to #58619 though, certainly not in scale, but at least in direction.

@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Mar 8, 2021
Closed
@bors
Copy link
Contributor

bors commented Mar 8, 2021

☔ The latest upstream changes (presumably #82896) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 8, 2021
@pierwill pierwill closed this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@varkor varkor

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pierwill @rust-highfive @varkor @bors @petrochenkov @jyn514