Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report missing cases of bare_trait_objects #82868

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Report missing cases of bare_trait_objects #82868

merged 3 commits into from
Mar 18, 2021

Conversation

petrochenkov
Copy link
Contributor

@petrochenkov petrochenkov commented Mar 7, 2021 •
edited
Loading

Fixes #65371

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 7, 2021
@petrochenkov petrochenkov mentioned this pull request Mar 7, 2021
Closed
@estebank
Copy link
Contributor

It should probably be reported later instead, only if the path ends up being successfully resolved.

maybe_lint_bare_trait is already using buffered_lints, but they are still emitted after parse. We could potentially delay them further and prune the list during resolve as appropriate.

@estebank
Copy link
Contributor

Beyond the concerns about now incorrect suggestions and the increased number of warnings for code in the wild, r=me. If you land this without addressing the two comments, please file a follow up ticket so we don't forget to fix them eventually.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2021
@petrochenkov
Copy link
Contributor Author

We could potentially delay them further and prune the list during resolve as appropriate.

It has to be delayed until type checking when type-relative associated items are resolved.
I'll try to look at this tomorrow.

@petrochenkov petrochenkov mentioned this pull request Mar 13, 2021
Merged
@petrochenkov
Copy link
Contributor Author

Blocked on #83092.

@petrochenkov petrochenkov added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 13, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 14, 2021
@Dylan-DPC
Rollup merge of rust-lang#83092 - petrochenkov:qspan, r=estebank
f540402 
More precise spans for HIR paths

`Ty::assoc_item` is lowered to `<Ty>::assoc_item` in HIR, but `Ty` got span from the whole path.
This PR fixes that, and adjusts some diagnostic code that relied on `Ty` having the whole path span.

This is a pre-requisite for rust-lang#82868 (we cannot report suggestions like `Tr::assoc` -> `<dyn Tr>::assoc` with the current imprecise spans).
r? `@estebank`
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 15, 2021
@Dylan-DPC
Rollup merge of rust-lang#83092 - petrochenkov:qspan, r=estebank
42b856e 
More precise spans for HIR paths

`Ty::assoc_item` is lowered to `<Ty>::assoc_item` in HIR, but `Ty` got span from the whole path.
This PR fixes that, and adjusts some diagnostic code that relied on `Ty` having the whole path span.

This is a pre-requisite for rust-lang#82868 (we cannot report suggestions like `Tr::assoc` -> `<dyn Tr>::assoc` with the current imprecise spans).
r? ``@estebank``
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 15, 2021
@Dylan-DPC
Rollup merge of rust-lang#83092 - petrochenkov:qspan, r=estebank
f49091d 
More precise spans for HIR paths

`Ty::assoc_item` is lowered to `<Ty>::assoc_item` in HIR, but `Ty` got span from the whole path.
This PR fixes that, and adjusts some diagnostic code that relied on `Ty` having the whole path span.

This is a pre-requisite for rust-lang#82868 (we cannot report suggestions like `Tr::assoc` -> `<dyn Tr>::assoc` with the current imprecise spans).
r? ```@estebank```
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 16, 2021
@Dylan-DPC
Rollup merge of rust-lang#83092 - petrochenkov:qspan, r=estebank
c73d157 
More precise spans for HIR paths

`Ty::assoc_item` is lowered to `<Ty>::assoc_item` in HIR, but `Ty` got span from the whole path.
This PR fixes that, and adjusts some diagnostic code that relied on `Ty` having the whole path span.

This is a pre-requisite for rust-lang#82868 (we cannot report suggestions like `Tr::assoc` -> `<dyn Tr>::assoc` with the current imprecise spans).
r? ``@estebank``
@bors

This comment has been minimized.

Sign in to view
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Mar 17, 2021
@Dylan-DPC
Rollup merge of rust-lang#83092 - petrochenkov:qspan, r=estebank
c0e1f65 
More precise spans for HIR paths

`Ty::assoc_item` is lowered to `<Ty>::assoc_item` in HIR, but `Ty` got span from the whole path.
This PR fixes that, and adjusts some diagnostic code that relied on `Ty` having the whole path span.

This is a pre-requisite for rust-lang#82868 (we cannot report suggestions like `Tr::assoc` -> `<dyn Tr>::assoc` with the current imprecise spans).
r? ```@estebank```
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Mar 17, 2021
@JohnTitor
Rollup merge of rust-lang#83092 - petrochenkov:qspan, r=estebank
70edab8 
More precise spans for HIR paths

`Ty::assoc_item` is lowered to `<Ty>::assoc_item` in HIR, but `Ty` got span from the whole path.
This PR fixes that, and adjusts some diagnostic code that relied on `Ty` having the whole path span.

This is a pre-requisite for rust-lang#82868 (we cannot report suggestions like `Tr::assoc` -> `<dyn Tr>::assoc` with the current imprecise spans).
r? ````@estebank````
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. labels Mar 17, 2021
@petrochenkov
Copy link
Contributor Author

Updated.

@petrochenkov petrochenkov removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 17, 2021
@petrochenkov petrochenkov added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 17, 2021
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@estebank
Copy link
Contributor

r=me after fixing clippy

@petrochenkov
Copy link
Contributor Author

@bors r=estebank

@bors
Copy link
Contributor

bors commented Mar 18, 2021

📌 Commit b48530b has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2021
@bors
Copy link
Contributor

bors commented Mar 18, 2021

⌛ Testing commit b48530b with merge 2aafe45...

@bors
Copy link
Contributor

bors commented Mar 18, 2021

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 2aafe45 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 18, 2021
@bors bors merged commit 2aafe45 into rust-lang:master Mar 18, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 18, 2021
@bors bors mentioned this pull request Mar 18, 2021
Merged
@Swatinem Swatinem mentioned this pull request Mar 22, 2021
Merged
@memoryruins memoryruins mentioned this pull request Mar 23, 2021
Closed
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Mar 25, 2021
@JohnTitor
Rollup merge of #83092 - petrochenkov:qspan, r=estebank
5476382 
More precise spans for HIR paths

`Ty::assoc_item` is lowered to `<Ty>::assoc_item` in HIR, but `Ty` got span from the whole path.
This PR fixes that, and adjusts some diagnostic code that relied on `Ty` having the whole path span.

This is a pre-requisite for rust-lang/rust#82868 (we cannot report suggestions like `Tr::assoc` -> `<dyn Tr>::assoc` with the current imprecise spans).
r? ````@estebank````
@dtolnay dtolnay mentioned this pull request May 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebank estebank estebank left review comments

Assignees

@estebank estebank

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.

Lint bare_trait_objects doesn't warn on traits used as types in paths
6 participants
@petrochenkov @rust-highfive @estebank @rust-log-analyzer @bors @rustbot