Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix copy_nonoverlapping #82967

Merged
merged 2 commits into from
Mar 10, 2021
Merged

fix copy_nonoverlapping #82967

merged 2 commits into from
Mar 10, 2021

Conversation

RalfJung
Copy link
Member

Fixes a bug introduced by #77511

r? @oli-obk
Fixes #82961

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 10, 2021
@RalfJung
Copy link
Member Author

I verified that the test fails without the PR (the first constant incorrectly raises an error).

@rust-log-analyzer

This comment has been minimized.

@RalfJung
Copy link
Member Author

This line length check in tests is really more annoying than helpful. :/

@oli-obk
Copy link
Contributor

oli-obk commented Mar 10, 2021

@bors r+

This line length check in tests is really more annoying than helpful. :/

yea... maybe we should teach it to ignore comments in tests

@bors
Copy link
Contributor

bors commented Mar 10, 2021

📌 Commit 4d74862 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2021
@RalfJung
Copy link
Member Author

@bors p=1 (fixes Miri)

@bors
Copy link
Contributor

bors commented Mar 10, 2021

⌛ Testing commit 4d74862 with merge a4d9624...

@bors
Copy link
Contributor

bors commented Mar 10, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing a4d9624 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 10, 2021
@bors bors merged commit a4d9624 into rust-lang:master Mar 10, 2021
@rustbot rustbot added this to the 1.52.0 milestone Mar 10, 2021
@RalfJung RalfJung deleted the copy-nonoverlap branch March 10, 2021 14:07
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 9, 2021
…Mark-Simulacrum

Make copy/copy_nonoverlapping fn's again

Make copy/copy_nonoverlapping fn's again, rather than intrinsics.

This a short-term change to address issue rust-lang#84297.

It effectively reverts PRs rust-lang#81167 rust-lang#81238 (and part of rust-lang#82967), rust-lang#83091, and parts of rust-lang#79684.
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 17, 2021
…Mark-Simulacrum

Make copy/copy_nonoverlapping fn's again

Make copy/copy_nonoverlapping fn's again, rather than intrinsics.

This a short-term change to address issue rust-lang#84297.

It effectively reverts PRs rust-lang#81167 rust-lang#81238 (and part of rust-lang#82967), rust-lang#83091, and parts of rust-lang#79684.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#82953
6 participants