-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include output stream in panic!()
documentation
#83254
Conversation
(rust-highfive has picked a reviewer for you, use r? to override) |
r? @Dylan-DPC @bors r+ rollup |
📌 Commit 55d9e0f has been approved by |
This is only what the default hook in I'm not objecting to documenting what happens by default with @bors r- |
This includes the description of the default `std` behavior and mentions the `panic::set_hook()` function.
I've incorporated your feedback @m-ou-se. I hope this is both helpful to a reader and concise while still being technically correct. Despite this file being in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looking better now. I have a few more comments:
Didn't intend to make this much noise in such a small change, apologies. |
Oh I'm very happy you're doing this! Clearly we were missing documentation here. Looks like we didn't even explain anywhere what happens with |
This looks great now. Thanks! @bors r+ rollup |
📌 Commit d5e45b5 has been approved by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few typos; otherwise LGTM, and I'm glad to see this documented.
Co-authored-by: Josh Triplett <josh@joshtriplett.org>
Thanks for the quick update! 👍 |
@bors r=m-ou-se,joshtriplett |
📌 Commit 19bd066 has been approved by |
Rollup of 8 pull requests Successful merges: - rust-lang#79986 (Only build help popup when it's really needed) - rust-lang#82570 (Add `as_str` method for split whitespace str iterators) - rust-lang#83244 (Fix overflowing length in Vec<ZST> to VecDeque) - rust-lang#83254 (Include output stream in `panic!()` documentation) - rust-lang#83269 (Revert the second deprecation of collections::Bound) - rust-lang#83277 (Mark early otherwise optimization unsound) - rust-lang#83285 (Update LLVM to bring in SIMD updates for WebAssembly) - rust-lang#83297 (Do not ICE on ty::Error as an error must already have been reported) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Fixes #83252.