Add Result::into_err where the Ok variant is the never type #83421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
joshtriplett
added
the
T-libs-api
|
Seems reasonable to me. What do others on @rust-lang/libs think? |
|
LGTM |
|
@bors r+ |
|
📌 Commit 3bf076e has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 25, 2021
Rollup of 8 pull requests Successful merges: - rust-lang#83041 (stabilize debug_non_exhaustive) - rust-lang#83349 (Remove Option::{unwrap_none, expect_none}.) - rust-lang#83420 (Add documentation for rustdoc-gui tests) - rust-lang#83421 (Add Result::into_err where the Ok variant is the never type) - rust-lang#83427 (small cleanups in rustc_errors / emitter) - rust-lang#83434 (Update RELEASES.md) - rust-lang#83440 (Use intra-doc link in core::cell) - rust-lang#83442 (LLVMWrapper: attractive nuisance macros) Failed merges: - rust-lang#83438 (Update RELEASES.md) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent of #66045 but for the inverse situation where
T: Into<!>rather thanE: Into<!>.I'm using the same feature gate name. I can't see why one of these methods would be OK to stabilize but not the other.
Tracking issue: #61695