Forbid priv where it has no effect
#8363
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is everywhere except struct fields and enum variants.
|
I'm in favor of this change but neglected to make it to the meeting on time to bring it up. @graydon ? |
|
I think the one remaining part of the issue would be to forbid visibility qualifiers on trait methods and on methods of trait implementations (if they're not already forbidden). Otherwise |
|
Closing; in my rollup. |
|
rollup in question: #8385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is everywhere except struct fields and enum variants.
This addresses concerns that I had in #8122, but it doesn't remove the keyword yet because it's still useful.